Hannah Wolfe

Results 170 comments of Hannah Wolfe

Hey @jaller94, thanks for the report. Weโ€™ll look into improving the error handling in the job - itโ€™s not expected that an error here is able to take the site...

Sounds like there's likely a windows path bug somewhere, would be fab if someone would PR a fix for it :)

Seems like there is a general issue where none of the assets get generated on windows for some reason. Would love to get a PR to fix this ๐Ÿ˜„

I've not seen this crop up before. Would be happy to accept a PR improving the behaviour :)

Hey @ahmed-sudani, thanks for taking the time to submit this PR and apologies for taking so long to review it - we got a bit behind! Whilst this change solves...

I'm going to close this fix in favour of the one that was merged here: https://github.com/TryGhost/Ghost-CLI/pull/1595 There is probably more work to do in terms of adding a try/catch and...

@s00500 I'm happy to reopen if you intend to work on it? ๐Ÿ™‚

I've reopened the issue - but short of letting you know that the admin client lives in `ghost/admin` now I wouldn't know where to look for this issue. It may...

Oh cool cc @daniellockyer our fork of mobiledoc-kit needs to pull in this patch: https://github.com/bustle/mobiledoc-kit/commit/305b1a2f33c51abd910d6b8ac6ec072347f26eeb