Roman Shanin

Results 40 issues of Roman Shanin

Current approach to handling admin account isn't correct (check comment inside the code): ``` fn visit_instruction(executor: &mut Executor, authority: &AccountId, isi: &InstructionBox) { // multihash equals to integration::upgrade::ADMIN_PUBLIC_KEY_MULTIHASH let admin_id...

Bug

Here is minimal example: ```rust #[test] fn test_bptree2_map_rangeiter_2() { let map = BptreeMap::from_iter([("ca", ()), ("cb", ()), ("a", ())]); let r = map.read(); assert!(r.range("b"..="bb").count() == 0); // return 2 } ```

I would like for `parameters` to look like this: ```json "parameters": [ { "sumeragi": { "block_time_ms": 2000 "commit_time_ms": 4000 } }, { "block": { "max_transactions": 512 } }, { "transaction":...

good first issue
api-changes

## Context We have `unstable_network` tests which are constantly failing in the CI. ### Solution Solutions consist of multiple parts: - @SamHSmith fix to use only genesis peer as client...

Tests

## Context Use published on `crates.io` version of `mv` crate (previous name `storage`) to be able to publish iroha itself. Partially unblock #2933.

## Description - Commit time is now linear function of view change index (capped at Duration::MAX) - Add more logs to track messages arriving to sumeragi Note: #4929 would also...

Consensus

## Description Instead of sending every view change proof only view change proof for current round and previous verified proof are sent. ### Linked issue Closes #4926 ### Benefits This...

Refactor
Optimization

While working on #4265 i've noticed that in case of heavy transaction increasing commit time does not helping. Additionally time between leader creating the block and other nodes receiving it...

Bug

Right now block signatures are used to discover topology for the next round. This approach gives benefit that unresponsive peers pushed out of topology. But this approach allow proxy tail...

Security

I've noticed that right now every proof within current block height is send on each view change suggestion. Which create redundant data transfer and it became heavier and heavier with...

Refactor
Optimization