openwebrtc icon indicating copy to clipboard operation
openwebrtc copied to clipboard

MpRTP modifications on OpenWebRTC

Open balazskreith opened this issue 9 years ago • 9 comments

Hi,

I would like to automatically merge from the master branch to keep this branch updated.

balazskreith avatar Oct 22 '15 12:10 balazskreith

@superdump @stefhak @zaheduzzaman how do we handle this one?

stefanalund avatar Nov 12 '15 09:11 stefanalund

@balazskreith - Is this ready for review? Does it work? Does it break any standard use cases?

superdump avatar Jan 23 '16 07:01 superdump

I need to finish the congestion control test implemented in the plugin, then I assemble it to the openwebrtc and then we can start the review process. Write to all of you soon.

On 23 January 2016 at 08:00, Robert Swain [email protected] wrote:

@balazskreith https://github.com/balazskreith - Is this ready for review? Does it work? Does it break any standard use cases?

— Reply to this email directly or view it on GitHub https://github.com/EricssonResearch/openwebrtc/pull/491#issuecomment-174155958 .

balazskreith avatar Jan 23 '16 14:01 balazskreith

Hi Curious. What kind of congestion control is it?

Skickat från min iPhone

23 jan. 2016 kl. 15:29 skrev balazskreith <[email protected]mailto:[email protected]>:

I need to finish the congestion control test implemented in the plugin, then I assemble it to the openwebrtc and then we can start the review process. Write to all of you soon.

On 23 January 2016 at 08:00, Robert Swain <[email protected]mailto:[email protected]> wrote:

@balazskreith https://github.com/balazskreith - Is this ready for review? Does it work? Does it break any standard use cases?

— Reply to this email directly or view it on GitHub https://github.com/EricssonResearch/openwebrtc/pull/491#issuecomment-174155958 .

— Reply to this email directly or view it on GitHubhttps://github.com/EricssonResearch/openwebrtc/pull/491#issuecomment-174190101.

IngJohEricsson avatar Jan 23 '16 16:01 IngJohEricsson

I try a combination of ScREAM and adaptive FEC.

On 23 January 2016 at 17:09, IngJohEricsson [email protected] wrote:

Hi Curious. What kind of congestion control is it?

Skickat från min iPhone

23 jan. 2016 kl. 15:29 skrev balazskreith <[email protected] mailto:[email protected]>:

I need to finish the congestion control test implemented in the plugin, then I assemble it to the openwebrtc and then we can start the review process. Write to all of you soon.

On 23 January 2016 at 08:00, Robert Swain <[email protected] mailto:[email protected]> wrote:

@balazskreith https://github.com/balazskreith - Is this ready for review? Does it work? Does it break any standard use cases?

— Reply to this email directly or view it on GitHub < https://github.com/EricssonResearch/openwebrtc/pull/491#issuecomment-174155958

.

— Reply to this email directly or view it on GitHub< https://github.com/EricssonResearch/openwebrtc/pull/491#issuecomment-174190101

.

— Reply to this email directly or view it on GitHub https://github.com/EricssonResearch/openwebrtc/pull/491#issuecomment-174196605 .

balazskreith avatar Jan 23 '16 21:01 balazskreith

Interesting And very interested to know your findings and if you encounter issues with SCReAM Ingemar

Skickat från min iPhone

23 jan. 2016 kl. 22:30 skrev balazskreith <[email protected]mailto:[email protected]>:

I try a combination of ScREAM and adaptive FEC.

On 23 January 2016 at 17:09, IngJohEricsson <[email protected]mailto:[email protected]> wrote:

Hi Curious. What kind of congestion control is it?

Skickat från min iPhone

23 jan. 2016 kl. 15:29 skrev balazskreith <[email protected]mailto:[email protected] mailto:[email protected]>:

I need to finish the congestion control test implemented in the plugin, then I assemble it to the openwebrtc and then we can start the review process. Write to all of you soon.

On 23 January 2016 at 08:00, Robert Swain <[email protected]mailto:[email protected] mailto:[email protected]> wrote:

@balazskreith https://github.com/balazskreith - Is this ready for review? Does it work? Does it break any standard use cases?

— Reply to this email directly or view it on GitHub < https://github.com/EricssonResearch/openwebrtc/pull/491#issuecomment-174155958

.

— Reply to this email directly or view it on GitHub< https://github.com/EricssonResearch/openwebrtc/pull/491#issuecomment-174190101

.

— Reply to this email directly or view it on GitHub https://github.com/EricssonResearch/openwebrtc/pull/491#issuecomment-174196605 .

— Reply to this email directly or view it on GitHubhttps://github.com/EricssonResearch/openwebrtc/pull/491#issuecomment-174224161.

IngJohEricsson avatar Jan 24 '16 09:01 IngJohEricsson

I updated openwebrtc and cerbero at https://github.com/multipath-rtp.

You can build it by git clone https://github.com/multipath-rtp/cerbero.

cerbero is altered by using gst-mprtp and https://github.com/multipath-rtp/openwebrtc recipe to build.

multipath-rtp/openwebrtc only differs from EricssonResearch/openwebrtc by its transport/owr_transport_agent., which contains the mprtp plugin and providing interfaces to join and detach subflows and the tests/test_send_receive, which join subflow while running the elements.

Its only the basic, gst-mprtp can control number of subflow and distribute a traffic a given ratio determined by the application uses it (i.e.: openwebrtc). There are tons of possibility and I also know there are tons of issues I have if you will start it reviewing. Please notify me if you tried it, or you have questions.

Balázs

On 24 January 2016 at 10:38, IngJohEricsson [email protected] wrote:

Interesting And very interested to know your findings and if you encounter issues with SCReAM Ingemar

Skickat från min iPhone

23 jan. 2016 kl. 22:30 skrev balazskreith <[email protected] mailto:[email protected]>:

I try a combination of ScREAM and adaptive FEC.

On 23 January 2016 at 17:09, IngJohEricsson <[email protected] mailto:[email protected]> wrote:

Hi Curious. What kind of congestion control is it?

Skickat från min iPhone

23 jan. 2016 kl. 15:29 skrev balazskreith <[email protected] mailto:[email protected] mailto:[email protected]>:

I need to finish the congestion control test implemented in the plugin, then I assemble it to the openwebrtc and then we can start the review process. Write to all of you soon.

On 23 January 2016 at 08:00, Robert Swain <[email protected] mailto:[email protected] mailto:[email protected]> wrote:

@balazskreith https://github.com/balazskreith - Is this ready for review? Does it work? Does it break any standard use cases?

— Reply to this email directly or view it on GitHub <

https://github.com/EricssonResearch/openwebrtc/pull/491#issuecomment-174155958

.

— Reply to this email directly or view it on GitHub<

https://github.com/EricssonResearch/openwebrtc/pull/491#issuecomment-174190101

.

— Reply to this email directly or view it on GitHub < https://github.com/EricssonResearch/openwebrtc/pull/491#issuecomment-174196605

.

— Reply to this email directly or view it on GitHub< https://github.com/EricssonResearch/openwebrtc/pull/491#issuecomment-174224161

.

— Reply to this email directly or view it on GitHub https://github.com/EricssonResearch/openwebrtc/pull/491#issuecomment-174272644 .

balazskreith avatar Feb 13 '16 19:02 balazskreith

I forgot to add that I am planning that longer mail to send you on next week.

On 13 February 2016 at 20:36, Balázs Kreith [email protected] wrote:

I updated openwebrtc and cerbero at https://github.com/multipath-rtp.

You can build it by git clone https://github.com/multipath-rtp/cerbero.

cerbero is altered by using gst-mprtp and https://github.com/multipath-rtp/openwebrtc recipe to build.

multipath-rtp/openwebrtc only differs from EricssonResearch/openwebrtc by its transport/owr_transport_agent., which contains the mprtp plugin and providing interfaces to join and detach subflows and the tests/test_send_receive, which join subflow while running the elements.

Its only the basic, gst-mprtp can control number of subflow and distribute a traffic a given ratio determined by the application uses it (i.e.: openwebrtc). There are tons of possibility and I also know there are tons of issues I have if you will start it reviewing. Please notify me if you tried it, or you have questions.

Balázs

On 24 January 2016 at 10:38, IngJohEricsson [email protected] wrote:

Interesting And very interested to know your findings and if you encounter issues with SCReAM Ingemar

Skickat från min iPhone

23 jan. 2016 kl. 22:30 skrev balazskreith <[email protected] mailto:[email protected]>:

I try a combination of ScREAM and adaptive FEC.

On 23 January 2016 at 17:09, IngJohEricsson <[email protected] mailto:[email protected]> wrote:

Hi Curious. What kind of congestion control is it?

Skickat från min iPhone

23 jan. 2016 kl. 15:29 skrev balazskreith <[email protected] mailto:[email protected] mailto:[email protected]>:

I need to finish the congestion control test implemented in the plugin, then I assemble it to the openwebrtc and then we can start the review process. Write to all of you soon.

On 23 January 2016 at 08:00, Robert Swain <[email protected] mailto:[email protected] mailto:[email protected]> wrote:

@balazskreith https://github.com/balazskreith - Is this ready for review? Does it work? Does it break any standard use cases?

— Reply to this email directly or view it on GitHub <

https://github.com/EricssonResearch/openwebrtc/pull/491#issuecomment-174155958

.

— Reply to this email directly or view it on GitHub<

https://github.com/EricssonResearch/openwebrtc/pull/491#issuecomment-174190101

.

— Reply to this email directly or view it on GitHub < https://github.com/EricssonResearch/openwebrtc/pull/491#issuecomment-174196605

.

— Reply to this email directly or view it on GitHub< https://github.com/EricssonResearch/openwebrtc/pull/491#issuecomment-174224161

.

— Reply to this email directly or view it on GitHub https://github.com/EricssonResearch/openwebrtc/pull/491#issuecomment-174272644 .

balazskreith avatar Feb 13 '16 19:02 balazskreith

This is open for over a year now. What's the current status of this PR? What's keeping it from being merged?

Zubnix avatar Feb 21 '17 12:02 Zubnix