codechecker icon indicating copy to clipboard operation
codechecker copied to clipboard

Implementation of Oauth of Github, Google and Microsoft

Open feyruzb opened this issue 1 year ago • 1 comments

fixes #4160

The right way it should look after logging in Screenshot from 2024-07-18 17-38-29

new added button to log in with github Screenshot from 2024-07-18 17-40-36

Changes:

  • added new buttons on login page for GitHub,Google Oauth authorization
  • added functions createLink and getOAuthToken into authentication.thrift
  • changed the current version of thrift API from 6.58.0 to 6.59.0
  • imported OAuth2Session in client.py
  • added a case for Oauth authorization in login_user function
  • added definition for thrift
  • imported OAuth2Session in authentication.py
  • added code to load the authentication configuration from
  • added oauth method for authentication in performLogin function
  • added oauth case in session manager
  • added fields for server_config file in the server_config.json
  • added oauth cases in auth.js
  • added reusable providers dict to server config to allow easier adding of new oauth providers
  • create a new function get_oauth_config for getting different providers configs in session manager
  • added documentation for configuration

feyruzb avatar Jul 18 '24 15:07 feyruzb

This looks like a real nice feature! Any update?

pdgendt avatar Aug 28 '24 10:08 pdgendt

Have you considered adding GitLab authentication?

LorandMarton avatar Jun 17 '25 12:06 LorandMarton

GitLab is not in focus for us, currently. However, the infrastructure is prepared for it.

bruntib avatar Jun 18 '25 09:06 bruntib

@bruntib I might give GitLab authentication a shot and open a merge request if things go well - if that’s okay with you.

LorandMarton avatar Jun 18 '25 10:06 LorandMarton

Sure, all contributions are welcome! Thank you in advance!

bruntib avatar Jun 19 '25 13:06 bruntib

@LorandMarton Hello, I will add Gitlab authentication in next month. I'm currently busy, preparing for my thesis defense.

feyruzb avatar Jun 19 '25 14:06 feyruzb