codechecker icon indicating copy to clipboard operation
codechecker copied to clipboard

[web] Weird truncation of hashes and file paths even on `1920×1080` resolution

Open whisperity opened this issue 3 years ago • 0 comments

Describe the bug

When viewing a bug report, several weird ...s (in some cases as ("…"), sometimes as literal "..." ...) appear instead of meaningful values. Something that looks like a Git hash (annotated as "Tracking branch", which in and of itself is some sort of a misnomer!) is truncated, and the file path is truncated.

The main problem is that I'm on 1920×1080 resolution, which is rather common even in these days. My browser is set to full screen (so I'm on full width)

CodeChecker version

6.21 stable (PyPI) release

To Reproduce

  1. Open a bug report (e.g., https://codechecker-demo.eastus.cloudapp.azure.com/Default/report-detail?review-status=Unreviewed&review-status=Confirmed%20bug&detection-status=New&detection-status=Reopened&detection-status=Unresolved&run=%2ataint_improvement_fixed&is-unique=off&diff-type=New&checker-msg=%2auntrusted%2a&checker-msg=%2ataint%2a&sort-by=bugPathLength&sort-asc=true&sort-desc=false&report-id=1356911&report-hash=7cafabdfa1aa3459cfee8da281bbea5a&report-filepath=%2Flocal%2Fpersistent_docker%2FCSA-measurements-driver-70%2Fmeasurements_workspace%2Ftmux%2Fstatus.c) with a semi-long file name (or "tracking branch" which is in fact a commit hash?) and observe:

CodeChecker UI 6.21 abbreviating the entire file path to oblivion, making it unreadable without the tool-tip

Expected behaviour

A meaningful part of the file path is shown, instead of hiding completely everything.

"… (aaaaaaaaaaaaa...)" for the "branch" is a bit nonsensical. How can this happen? Both the … and the truncated hash show the full hash in the tool-tip. (Sorry, I did not find a meaningful way to screenshot this...) If we do not have a branch name (the original analysis was created in a detached-HEAD state?) then the first … should not be there. As for the hashes, it is customary in Git to abbreviate commit hashes to 7 hexadecimal characters by default, and only use additional characters if the first 7 chars would be ambiguous. I am sure we ask Git how many chars are needed: git log --abbrev-commit produces commit d8d1c5886922 on a large repository like torvalds/linux or llvm/llvm-project, but only 7 chars commit 8bda4c7 on a small repository like whisperity/Dotfiles. This information would be useful to automatically abbreviate to the proper length, without having to manually do something that's related to the current screen/viewport width.

Desktop (please complete the following information)

  • OS: Ubuntu 20.04.6 LTS
  • Browser: Firefox 112.0
  • Resolution: 1920×1080

Additional context

On 4K resolution (3840×2160) the file path is not truncated, but the Git hash still is, and then there is a lot of unused padding in the middle of the top bar:

The same issue does not appear using 4K resolution

Supporting 1920×1080 "normally" should be a priority still, as a lot of development and consumer machines are still using natively FullHD screens, and especially on mobile devices only the recent major and very expensive devices are exploring having FullHD-ish and 2K screens. According to the Steam Hardware Survey data of March 2023, 64.28% of people use 1920×1080:

Steam Hardware Survey, March 2023 results, with the "Primary Display Resolution" breakdown opened

whisperity avatar Apr 13 '23 16:04 whisperity