CodeCompass icon indicating copy to clipboard operation
CodeCompass copied to clipboard

Added calculation for relational cohesion metric

Open kmkristof opened this issue 1 year ago • 3 comments

Closes #680

Added -m flag to the parser which can be used to specify modules. The user is expected to input a path to a file in which the paths to the modules are listed. If no modules are specified the default behaviour is to treat every directory under the input paths as a module.

  • [ ] Add test cases

kmkristof avatar May 08 '24 09:05 kmkristof

@kmkristof The PR was marked ready, but the description says the tests are still missing. (And there are indeed no tests in the changeset.) Please add the missing unit tests.

mcserep avatar Jul 01 '24 13:07 mcserep

@kmkristof The PR contains various commits unrelated to this PR for some reason. This makes it hard to review the PR.
Please rebase your branch onto master and force push it.

mcserep avatar Jul 05 '24 14:07 mcserep

@mcserep I added the necessary data and definitions for unit testing however i ran into a problem. For example when looking at plugins/cpp_metrics/test/sources/parser/RelationalCohesion/MultipleTypesInModuleWithRelations/RelationByFunctionParameter/relatedByFPA no typeHash is generated for the class itself (as it doesn't become a CppTypedEntity). This means that when i find a reference to this type i cannot connect it to the definition. How do you suggest i solve this issue?

kmkristof avatar Jul 07 '24 08:07 kmkristof

Superseded by #795

mcserep avatar May 27 '25 03:05 mcserep