Fix recursive caller nodes

Open andocz opened this issue 3 years ago • 1 comments

Fixes #544, which was caused by the children of the child caller nodes being set incorrectly. Recursions in the tree are also avoided now.

There is one issue remaining that I need some feedback on. When the child caller nodes are created, the reference count after their name is appended to instead of replaced, which means reference counts keep piling up as we go deeper in the tree. See "Caller(4)(8)(1)" in this screenshot. This is not intentional, is it? In that case I can fix it too.

Mar 09 '22 04:03 andocz

Great work finding the source of this issue!

There is one issue remaining that I need some feedback on. When the child caller nodes are created, the reference count after their name is appended to instead of replaced, which means reference counts keep piling up as we go deeper in the tree. See "Caller(4)(8)(1)" in this screenshot.

No, it's not a feature, but a bug 😄

Mar 09 '22 11:03 mcserep