Voxlap icon indicating copy to clipboard operation
Voxlap copied to clipboard

Voxlap Refactored: 6.1

Open Ericson2314 opened this issue 11 years ago • 6 comments

After this is done I can't mutate the history so I rather do it after the initial port. :)

Ericson2314 avatar Apr 04 '13 21:04 Ericson2314

Making progress here, but the global variables are making it tricky. I've started pegging them to their associated functions in the hope that we can have a clear understanding of what they all do, and where they get used. Do you have any experience with IDA pro? I already have a half formed signature file from stuff I was working on before, which may come in handy for debugging. Maybe we can discuss on IRC sometime.

Lensman avatar Apr 05 '13 18:04 Lensman

I have used IDA a bit, so feel free to consider that. And with this I've flipped again. it's fine to refactor now, but when we are done and have a testing suit I may redo the history on an entirely new branch so that no commit breaks any tests.

So yeah, TL;DR what you are doing on conservative is great.

Ericson2314 avatar Apr 05 '13 19:04 Ericson2314

I understand what you mean there, something with this many shared globals will need to be treated with kid gloves once it's 'working'.

Lensman avatar Apr 06 '13 19:04 Lensman

Hey @Lensman, haven't heard from you in a while. Are you still interested in working on Voxlap when I have time again mid May?

Ericson2314 avatar Apr 30 '13 04:04 Ericson2314

@lensman Oh, for some reason github wasn't notifying me that you had pushed to your re-factored repository. Now that you got a good deal of progress in there, do you think we could rebase off my initial commit? the first dump in the repo makes for kind of a drastic commit, so if we could retroactively redo that process and then rebase what you have I think that would be best.

Ericson2314 avatar May 09 '13 18:05 Ericson2314

And are you using CMake to build? If so great, I am sick of maintaining multiple Makefiles.

Ericson2314 avatar May 09 '13 18:05 Ericson2314