Lnk icon indicating copy to clipboard operation
Lnk copied to clipboard

Update VolumeInfo.cs

Open SteAmeR opened this issue 2 months ago • 4 comments

Issue #23

SteAmeR avatar Oct 01 '25 18:10 SteAmeR

Any progress?

SteAmeR avatar Oct 06 '25 18:10 SteAmeR

i dont have any issues with this, but the concern is, how far do you keep chasing corruption?

EricZimmerman avatar Oct 06 '25 18:10 EricZimmerman

Maybe keep strict validation for mandatory structures, but make optional blocks best-effort — skip if corrupted instead of failing the whole parse. This way we don’t chase corruption, we just don’t give up too early :\ So maybe the ideal balance here is:

  • Fail-fast for mandatory sections.
  • Best-effort for optional blocks — wrap them in try/catch and skip on corruption instead of stopping the whole parse. This way, we don’t “chase” corruption — we just don’t give up too early. It also matches the resilience of the Windows Shell’s native LNK resolver.

SteAmeR avatar Oct 06 '25 20:10 SteAmeR

i like this approach. id have to look at the specs to confirm, but what blocks fall under each category?

EricZimmerman avatar Oct 07 '25 15:10 EricZimmerman