DREAM icon indicating copy to clipboard operation
DREAM copied to clipboard

Published 20 hours ago • verified publisher icon EricSteinberger

Bug in CardEmbedding

Open ohwi opened this issue 3 years ago • 3 comments

https://github.com/EricSteinberger/DREAM/blob/bfe21bbb0f60ab27a1af9774308efbbbd41e68c4/PokerRL/rl/neural/CardEmbedding.py#L64

Since the variable n means the number of cards dealt in the round, added number must be multiplied by 3, which means the length of (rank, suit, card).

I think that this line needs to be off += n * 3.

ohwi avatar Apr 09 '21 03:04 ohwi

Thanks! Did you test this in the debugger or so? That's interesting. I'm not sure if it's true but it might be

EricSteinberger avatar Apr 11 '21 11:04 EricSteinberger

I agree with ohwi.

LucasCJYSDL avatar Jun 13 '23 03:06 LucasCJYSDL