Compilation fails on macOS due to .zip(devices)

[vlbosch]

Describe the bug

Log output for building with --features metal:

error[E0425]: cannot find value devicesin this scope --> mistralrs-core/src/pipeline/isq.rs:194:26 | 194 | .zip(devices) | ^^^^^^^ help: a local variable with a similar name exists:device`

warning: unused import: indicatif::ProgressIterator --> mistralrs-core/src/pipeline/isq.rs:191:21 | 191 | use indicatif::ProgressIterator; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: #[warn(unused_imports)] on by default

For more information about this error, try rustc --explain E0425. warning: mistralrs-core (lib) generated 1 warning error: could not compile mistralrs-core (lib) due to 1 previous error; 1 warning emitted warning: build failed, waiting for other jobs to finish... vincent@MBPM3MVLB mistral.rs % cargo build --release --features metal Compiling mistralrs-core v0.2.5 (/Users/vincent/LLM/mistralrs/mistral.rs/mistralrs-core) error[E0425]: cannot find value devices in this scope --> mistralrs-core/src/pipeline/isq.rs:194:26 | 194 | .zip(devices) | ^^^^^^^ help: a local variable with a similar name exists: device

warning: unused import: indicatif::ProgressIterator --> mistralrs-core/src/pipeline/isq.rs:191:21 | 191 | use indicatif::ProgressIterator; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: #[warn(unused_imports)] on by default

For more information about this error, try rustc --explain E0425. warning: mistralrs-core (lib) generated 1 warning error: could not compile mistralrs-core (lib) due to 1 previous error; 1 warning emitted`

Latest commit or version

Which commit or version you ran with: b20b818

Proposed solution

I changed line 194 in isq.rs to .zip(devices_and_dtypes) and that resolved the issue. Also seemed the correct solution to me, since that variable is also used in the non-metal devices.