Support tekken tokenizer conversion

[EricLBuehler]

Summary by CodeRabbit

• New Features

  • Added support for loading and using a new tokenizer format ("tekken.json"), enabling broader compatibility with different tokenizer files.

• Improvements

  • The app now prioritizes "tekken.json" over "tokenizer.json" when both are available, with a fallback mechanism for tokenizer file selection.
  • Expanded public access to utility modules and tokenizer functionality for easier integration and use in external projects.

[coderabbitai[bot]]

Walkthrough

The changes introduce support for a new tokenizer format, "tekken.json," across the codebase. This includes updating macros to prioritize "tekken.json" over "tokenizer.json," implementing logic to load and convert "tekken.json" files, and making relevant modules and functions public. The tiktoken-rs dependency is also added.

Changes

File(s)	Change Summary
Cargo.toml, mistralrs-core/Cargo.toml	Added tiktoken-rs as a workspace dependency.
mistralrs-core/src/lib.rs	Changed utils module visibility from private to public.
mistralrs-core/src/utils/mod.rs	Changed tokenizer module visibility from crate-private to public.
mistralrs-core/src/utils/tokenizer.rs	Added support for "tekken.json" tokenizer format, new structs/functions, made get_tokenizer public.
mistralrs-core/src/pipeline/macros.rs	Modified macros to prefer "tekken.json" over "tokenizer.json" and handle missing files gracefully.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant PipelineMacros
    participant UtilsTokenizer

    User->>PipelineMacros: Request model/tokenizer paths
    PipelineMacros->>PipelineMacros: Check for "tekken.json" in directory
    alt "tekken.json" found
        PipelineMacros->>UtilsTokenizer: Load "tekken.json"
        UtilsTokenizer->>UtilsTokenizer: Parse Tekken format, convert to HuggingFace JSON
        UtilsTokenizer-->>PipelineMacros: Return Tokenizer
    else "tokenizer.json" found
        PipelineMacros->>UtilsTokenizer: Load "tokenizer.json"
        UtilsTokenizer-->>PipelineMacros: Return Tokenizer
    else None found
        PipelineMacros-->>User: Return empty path or error
    end

Suggested labels

codex

Poem

A new tokenizer hops in, named Tekken,
With base64 vocab, it’s not what you’d reckon!
The macros now peek for this file first,
And public utils quench your thirst.
With tiktoken-rs, we’re ready to run—
More formats supported, more fun in the sun!
🐇✨

✨ Finishing Touches

• [ ] 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions[bot]]

Code Metrics Report

===============================================================================
 Language            Files        Lines         Code     Comments       Blanks
===============================================================================
 C Header                3           62           53            0            9
 CSS                     1          473          408           14           51
 Dockerfile              1           44           24           10           10
 HTML                    1           78           64            5            9
 JavaScript              7         1397         1068          180          149
 JSON                   18          282          279            0            3
 Makefile                1            6            5            0            1
 Python                 92         4530         3813          185          532
 Shell                   1           63           26           18           19
 Plain Text              3         3723            0         2413         1310
 TOML                   23          846          778           11           57
 YAML                    2           21           19            2            0
-------------------------------------------------------------------------------
 Jupyter Notebooks       3            0            0            0            0
 |- Markdown             2           77           32           31           14
 |- Python               2          205          178            1           26
 (Total)                            282          210           32           40
-------------------------------------------------------------------------------
 Markdown               69         6171            0         4657         1514
 |- BASH                14          203          190            7            6
 |- JSON                 9          436          436            0            0
 |- Python              12          391          326           24           41
 |- Rust                29         1123          945           30          148
 |- TOML                 2           75           63            0           12
 (Total)                           8399         1960         4718         1721
-------------------------------------------------------------------------------
 Rust                  397       140359       124634         3209        12516
 |- Markdown           191         4084          284         3259          541
 (Total)                         144443       124918         6468        13057
===============================================================================
 Total                 622       158055       131171        10704        16180
===============================================================================