inventory-hunter icon indicating copy to clipboard operation
inventory-hunter copied to clipboard

Not working with Uk amazon

Open SamShanks1 opened this issue 4 years ago • 8 comments

When using this with uk amazon it says: unable to convert "£140.45" to float... caught exception: could not convert string to float: '£140.45' however it works with US amazin

SamShanks1 avatar Dec 02 '20 17:12 SamShanks1

Can you try manually editing the Dockerfile, changing these three lines:

ENV LC_ALL en_US.UTF-8
ENV LANG en_US.UTF-8
ENV LANGUAGE en_US.UTF-8

to:

ENV LC_ALL en_GB.UTF-8
ENV LANG en_GB.UTF-8
ENV LANGUAGE en_GB.UTF-8

EricJMarti avatar Dec 02 '20 18:12 EricJMarti

Works now Thank you <3

SamShanks1 avatar Dec 02 '20 18:12 SamShanks1

One more thing the UK site ebuyer uses add-to-basket instead of add-to-cart so it thinks its out of stock is it possible to add it so it checks for that as well

SamShanks1 avatar Dec 02 '20 18:12 SamShanks1

Just checked in this change: https://github.com/EricJMarti/inventory-hunter/commit/a90683d0a408934af219f0a03d800c79681093c9

Can you pull in the latest code, rebuild the docker image, and try again?

EricJMarti avatar Dec 02 '20 18:12 EricJMarti

Is it possible to fix Amazon SG as well? It uses S$ which messed up the code

Burito55 avatar Dec 03 '20 07:12 Burito55

I am also having this issue however, editing the Dockerfile isn't fixing it for me.

jamesearls avatar Dec 08 '20 15:12 jamesearls

Can you try again with the latest image? I recently committed a change that was intended to ignore currency symbols.

EricJMarti avatar Dec 16 '20 23:12 EricJMarti

@EricJMarti I have pulled down the recent changes and I am getting SCRAPE FAILED on amazon.co.uk. The Float issue is fixed. (edit: fixed misleading wording & grammar)

jamesearls avatar Dec 20 '20 00:12 jamesearls