momask-codes icon indicating copy to clipboard operation
momask-codes copied to clipboard

Replicating the results of the pre-trained models.

Open weihaosky opened this issue 1 year ago • 19 comments

Thanks for releasing this amazing work! However, I cannot replicate the results of the pre-trained models using the provided code. The results after training with the provided code are

  • RVQ Reconstruction:
FID: 0.032, conf. 0.000                                                                                     
Diversity: 9.676, conf. 0.054                                                                       
TOP1: 0.507, conf. 0.003, TOP2. 0.697, conf. 0.002, TOP3. 0.794, conf. 0.002                                
Matching: 3.024, conf. 0.009                                                                                
MAE:0.042, conf.0.000
  • Text2motion Generation
FID: 0.148, conf. 0.006
Diversity: 9.576, conf. 0.079
TOP1: 0.504, conf. 0.003, TOP2. 0.699, conf. 0.003, TOP3. 0.795, conf. 0.002
Matching: 3.062, conf. 0.010
Multimodality:1.327, conf.0.044

May I ask where is the problem? Many thanks!

weihaosky avatar Feb 20 '24 09:02 weihaosky

Hi, thanks for your interest!

We are happy to figure out the problem together with you. Could you please provide the configures for training (opt file) and testing (scripts) for each stage?

Murrol avatar Feb 20 '24 14:02 Murrol

I just use the provided code and commands without any change. vq training: opt.txt mtrans training: opt.txt rtrans training: opt.txt vq test: rvq_nq6.log mtrans test: evaluation.log

weihaosky avatar Feb 21 '24 01:02 weihaosky

I just use the provided code and commands without any change. vq training: opt.txt mtrans training: opt.txt rtrans training: opt.txt vq test: rvq_nq6.log mtrans test: evaluation.log

Hi wenhao, thanks for your info.

I've checked the configures and corrected the scripts in our README. We used --gamma 0.05 to train the rvq. I just re-trained the rvq and got the following results:

image

Hope you will find it useful.

Murrol avatar Feb 21 '24 09:02 Murrol

I just use the provided code and commands without any change. vq training: opt.txt mtrans training: opt.txt rtrans training: opt.txt vq test: rvq_nq6.log mtrans test: evaluation.log

Hi wenhao, thanks for your info.

I've checked the configures and corrected the scripts in our README. We used --gamma 0.05 to train the rvq. I just re-trained the rvq and got the following results:

image Hope you will find it useful.

Hi, after setting --gamma 0.05 I got a worse result: image

net_best_fid.tar final result, epoch 36
        FID: 0.040, conf. 0.000
        Diversity: 9.598, conf. 0.097
        TOP1: 0.506, conf. 0.002, TOP2. 0.696, conf. 0.002, TOP3. 0.793, conf. 0.002
        Matching: 3.027, conf. 0.008
        MAE:0.039, conf.0.000

weihaosky avatar Feb 22 '24 01:02 weihaosky

I meet the same problem and get the same results with @weihaosky . Have you solved the problem? Thanks.

aszxnm avatar Mar 26 '24 07:03 aszxnm

I meet the same problem and get the same results with @weihaosky . Have you solved the problem? Thanks.

No. I still cannot replicate the results.

weihaosky avatar Mar 27 '24 07:03 weihaosky

Have you solved the problem now? @weihaosky @aszxnm Thanks.

seoneun avatar Apr 30 '24 05:04 seoneun

the same for me...

I meet the same problem and get the same results with @weihaosky . Have you solved the problem? Thanks.

No. I still cannot replicate the results.

JHang2020 avatar May 01 '24 09:05 JHang2020

The same for me, and another confusing problem is the MPJPE of the reconstruction setting on the kit dataset: 1719153702064

The command I run is python eval_t2m_vq.py --gpu_id 0 --name rvq_nq6_dc512_nc512_noshare_qdp0.2_k --dataset_name kit --ext rvq_nq6, and I used the default pretrained checkpoint.

Similarly, when I test it on the Humanml dataset, the results is : image

It is obvious that the MPJPE results on these two datasets differ by several orders of magnitude. Does anyone else have the same problem?

wang-zm18 avatar Jun 23 '24 14:06 wang-zm18

I just use the provided code and commands without any change. vq training: opt.txt mtrans training: opt.txt rtrans training: opt.txt vq test: rvq_nq6.log mtrans test: evaluation.log

Hi wenhao, thanks for your info. I've checked the configures and corrected the scripts in our README. We used --gamma 0.05 to train the rvq. I just re-trained the rvq and got the following results: image Hope you will find it useful.

Hi, after setting --gamma 0.05 I got a worse result: image

net_best_fid.tar final result, epoch 36
        FID: 0.040, conf. 0.000
        Diversity: 9.598, conf. 0.097
        TOP1: 0.506, conf. 0.002, TOP2. 0.696, conf. 0.002, TOP3. 0.793, conf. 0.002
        Matching: 3.027, conf. 0.008
        MAE:0.039, conf.0.000

Have you solved the problem now? @weihaosky @aszxnm

Thanks.

HitBadTrap avatar Jun 23 '24 15:06 HitBadTrap

I just use the provided code and commands without any change. vq training: opt.txt mtrans training: opt.txt rtrans training: opt.txt vq test: rvq_nq6.log mtrans test: evaluation.log

Hi wenhao, thanks for your info. I've checked the configures and corrected the scripts in our README. We used --gamma 0.05 to train the rvq. I just re-trained the rvq and got the following results: image Hope you will find it useful.

Hi, after setting --gamma 0.05 I got a worse result: image

net_best_fid.tar final result, epoch 36
        FID: 0.040, conf. 0.000
        Diversity: 9.598, conf. 0.097
        TOP1: 0.506, conf. 0.002, TOP2. 0.696, conf. 0.002, TOP3. 0.793, conf. 0.002
        Matching: 3.027, conf. 0.008
        MAE:0.039, conf.0.000

Have you solved the problem now? @weihaosky @aszxnm

Thanks.

No. I still cannot replicate the results.

aszxnm avatar Jun 24 '24 07:06 aszxnm

Thank you all for your attempts to replicate the results. I just got some time to re-train the masked-transformer and res-transformer using our released code. Here are some results for your reference:

image

I used the rvq checkpoint I obtained here https://github.com/EricGuo5513/momask-codes/issues/27#issuecomment-1956264373. I used the following scripts to train the m-trans and r-trans:

python train_t2m_transformer.py --name mtrans_replicate --gpu_id 1 --dataset_name t2m --batch_size 64 --vq_name rvq_replicate
python train_res_transformer.py --name rtrans_replicate --gpu_id 2 --dataset_name t2m --batch_size 64 --vq_name rvq_replicate --cond_drop_prob 0.2 --share_weight

evaluation script:

python eval_t2m_trans_res.py --res_name rtrans_replicate --dataset_name t2m --name mtrans_replicate --gpu_id 1 --cond_scale 4 --time_steps 10 --ext evaluation_replicate

The above results are obtained from these scripts without any modification to this code base. The replicate experiments were done on a single RTX 2080 Ti GPU, torch==1.7.1. For the processed dataset cloned from the original HumanML3D project, please send inquiry to [email protected] or [email protected]

Murrol avatar Jun 24 '24 08:06 Murrol

https://github.com/EricGuo5513/momask-codes/issues/27#issuecomment-2185009113 Does anybody knows the problem?

wang-zm18 avatar Jun 29 '24 14:06 wang-zm18

The same for me, and another confusing problem is the MPJPE of the reconstruction setting on the kit dataset: 1719153702064

The command I run is python eval_t2m_vq.py --gpu_id 0 --name rvq_nq6_dc512_nc512_noshare_qdp0.2_k --dataset_name kit --ext rvq_nq6, and I used the default pretrained checkpoint.

Similarly, when I test it on the Humanml dataset, the results is : image

It is obvious that the MPJPE results on these two datasets differ by several orders of magnitude. Does anyone else have the same problem?

The scale is different. Check the Mean.py files.

Murrol avatar Jun 29 '24 16:06 Murrol

I re-download the KIT-ML dataset from Link directly. While it still remains this problem. Maybe it is not the mean problem?Thank you in advance! @Murrol

wang-zm18 avatar Jun 30 '24 00:06 wang-zm18

https://github.com/EricGuo5513/momask-codes/issues/27#issuecomment-2198380894

Any other suggestions? Thanks!

wang-zm18 avatar Jul 06 '24 08:07 wang-zm18

I re-download the KIT-ML dataset from Link directly. While it still remains this problem. Maybe it is not the mean problem?Thank you in advance! @Murrol

Scale difference means that the scale of AMASS(HumanML3D) and kit data is different. Take an example, inch vs cm.

"the MPJPE results on these two datasets differ by several orders of magnitude" should not be an issue.

Murrol avatar Jul 07 '24 01:07 Murrol

I re-download the KIT-ML dataset from Link directly. While it still remains this problem. Maybe it is not the mean problem?Thank you in advance! @Murrol

Scale difference means that the scale of AMASS(HumanML3D) and kit data is different. Take an example, inch vs cm.

"the MPJPE results on these two datasets differ by several orders of magnitude" should not be an issue.

Oh, thanks! I checked the range of means from these two datasets, the mean of KIT datasets is three orders of magnitude higher than that of HumanML3D on average. Thank you! @Murrol

wang-zm18 avatar Jul 08 '24 01:07 wang-zm18

Thank you all for your attempts to replicate the results. I just got some time to re-train the masked-transformer and res-transformer using our released code. Here are some results for your reference:

image

I used the rvq checkpoint I obtained here #27 (comment). I used the following scripts to train the m-trans and r-trans:

python train_t2m_transformer.py --name mtrans_replicate --gpu_id 1 --dataset_name t2m --batch_size 64 --vq_name rvq_replicate
python train_res_transformer.py --name rtrans_replicate --gpu_id 2 --dataset_name t2m --batch_size 64 --vq_name rvq_replicate --cond_drop_prob 0.2 --share_weight

evaluation script:

python eval_t2m_trans_res.py --res_name rtrans_replicate --dataset_name t2m --name mtrans_replicate --gpu_id 1 --cond_scale 4 --time_steps 10 --ext evaluation_replicate

The above results are obtained from these scripts without any modification to this code base. The replicate experiments were done on a single RTX 2080 Ti GPU, torch==1.7.1. For the processed dataset cloned from the original HumanML3D project, please send inquiry to [email protected] or [email protected]

Hello, I have some doubts regarding the reproduction of results. Currently, the minimum FID value I am getting while replicating the results on t2m is 0.059, and other metrics are normal. However, after adding certain modules, the FID value is 0.047, but in your paper, the FID value is 0.045. I would like to know if this is an improvement? I am a bit unclear whether my modifications are effective, or if, in fact, my reproduced results are not correct.

Suzixin7894946 avatar Jul 26 '24 03:07 Suzixin7894946