Eric Forgy
Eric Forgy
From what I understand at the moment (which could be wrong), I should be able to compare these two files: 1. https://github.com/JuliaLang/Julia.tmbundle/blob/master/Syntaxes/Julia.tmLanguage and 2. https://github.com/JuliaLang/atom-language-julia/blob/master/grammars/julia.cson and transfer any differences from...
I notice above the use of keywords `mean` and `sigma`. Does that feel inconsistent? If you write out `sigma`, maybe `mu` is better. Or if you write out `mean`, maybe...
**Update: `pure` Mutability Blocks Delegatecall-Compatible Storage Slot Overrides** Upon further inspection, I realized that although `Initializable` provides a `virtual` storage slot function (`_initializableStorageSlot()`), it is marked as `pure`. This prevents...
Hi @ernestognw, You're right — just making the storage slot getters `virtual` (while keeping them `pure`) would be sufficient for my use case. I appreciate you pointing that out. If...
Hi again, After realizing the upgradeable contracts are transpiled from the base repo, I looked into adjusting the storage slot logic more directly. The specific problem I’m addressing is in...
While investigating how the transpiler works, I realized that `ReentrancyGuardTransient.sol` in `@openzeppelin/contracts` is already upgrade-compatible, since it relies on a named storage slot (and requires no initialization). Because of that,...
Thanks so much - I really appreciate the thoughtful response and your willingness to move forward with this change 🙏
Hi @amxx, Thank you for the thoughtful response and proposed alternative. Just to clarify upfront: I’ve moved away from the `__self` approach after @ernestognw’s earlier feedback. The current proposal relies...
Quick follow-up: after fixing the directory creation issue in `run.js`, I ran into a second problem when trying to commit the fix — the ESLint pre-commit hook fails with: ```...