binance-futures-trading-bot
binance-futures-trading-bot copied to clipboard
Project structure needs improvement
Hello, I'm very interested in this project development thou I noticed that many things could be enhanced. Among them:
- main.py - file structure, imports and functions should be adjusted.
- Some of the variables should be moved to config
is_price_increasing = False
is_price_decreasing = False
is_macd_increasing = False
is_macd_decreasing = False
is_macd_positive = False
is_macd_negative = False
account_available_balance = 0
total_account_balance = 0
is_bot_started = False
- Do not use star imports (as this is known to be programming anti-pattern in Python)
- Make project structure by decomposing logic, introducing OOP
- Improve logging by logging strictly in JSON formats (thus logs can be analyzed and processed by other tools)
- Create separate config file (in JSON format) or let the user specify variables by the .env file - for the ease of use
Plus, code style is not so good, pre-commit needs to be included in the project. If you find my message useful, then message me an email - I can help in development by guiding and reviewing, but not so much by commits. Best Regards, Bulat