foundryvtt-lancer icon indicating copy to clipboard operation
foundryvtt-lancer copied to clipboard

[BUG] Actions Nested in Frame Traits and Core Actives/Passives Don't Print to Chat

Open msprijatelj opened this issue 2 years ago • 2 comments

Describe the bug Clicking the "Action" button nested in a Mech Sheet fails to print the Action to chat and instead throws an error in the console.

To Reproduce Steps to reproduce the behavior:

  1. Create a new Mech Sheet.
  2. Drag the Black Witch frame from the Compendium onto the sheet.
  3. Navigate to the <MECH//LOADOUT> tab.
  4. Click on the "Reaction" button under the Mag Parry action within the Mag Parry trait.
  5. Observe that nothing is printed to chat.
  6. Repeat steps 2-5 with Hydra, instead clicking the "Quick" button for each Drone.
  7. Repeat steps 2-6 with Mourning Cloak, instead clicking the "Full" button for Blinkspace Jump.

Expected behavior Clicking the "Action" button for an action nested in a frame trait or core passive/active prints the action to chat (and potentially hooks into the action tracker functionality).

Screenshots Screenshot is from the 1.4.0-beta.1 prerelease, but the bug is also present on Lancer 1.3.1. image

Platform (please complete the following information):

  • OS: Windows 10
  • Browser: Foundry App
  • Foundry version v9.280 and v10.291
  • Lancer system version v1.3.1 and v1.4.0-beta.1

Additional context If Zheng from the Long Rim is installed, using Zheng to test will save some time since it has a Trait with a Free action and a Core Passive with a Free Action.

Discord contact info Valkyrion#6196

msprijatelj avatar Jan 05 '23 04:01 msprijatelj

I just tested this and I'm not sure if it's fixed as the reporter intended or not. In the current version mag parry doesn't even have a reaction sub-popout at all. Hydra has all the drones listed but no buttons to activate them. Not sure if that's intended or not. The Use full button on the Mourning Cloak is working as intended.

Image

Image

Image

I also tested it with the mimic mesh system from Gorgon. Instead of submenus in the popout it just has separate buttons, which works well and is intuitive.

Image

OS: Windows 10 Browser: Chrome Foundry version: 11.315 Lancer system version: 2.0.0

Davis-K-Johnson avatar Mar 11 '24 16:03 Davis-K-Johnson

@Davis-K-Johnson glad to hear about the Full Action for Mourning Cloak; that means that at least the buttons for “Core Passives” are functioning. Missing Action buttons on the other frame traits is a bit worrying, though.

msprijatelj avatar Mar 11 '24 17:03 msprijatelj

Just checked on the trait actions - there was indeed a bug there! Simple one line fix, they now render on the sheet and print to chat when clicked!

Eranziel avatar May 05 '24 23:05 Eranziel