[BUG] Pilot Armor cannot be increased above 1

[Tenemach]

Describe the bug Exactly what the title says - a pilot's armor value does not go above 1 even when wearing a hardsuit that provides more.

To Reproduce Steps to reproduce the behavior:

1. Create a pilot
2. Drag'n'drop a Heavy Hardsuit (or any hardsuit modified to give 2 or more armor) onto the pilot
3. Behold the top bar display a big ol' 1 next to the armor score anyway

Expected behavior The top bar must display the same armor value as the one specified in the hardsuit's properties

Screenshots

Platform (please complete the following information):

• OS: Windows
• Browser: Chrome
• Foundry version v9.280
• Lancer system version 1.3.1

Additional context Tried adding the bonus (ID: pilot_armor, Value: 2) multiple times on the same hardsuit, does nothing. Tried increasing or decreasing it beyond normal limits, no value besides 0 or 1 showed up on the tab.

Discord contact info Tenebrae Machina#2022

[Eranziel]

Going to expand this to mechs as well. v1.x limits mech armour to 4, which makes for manual bookkeeping with White Witch.

[Davis-K-Johnson]

The pilot armor works at the very least now.

Speaking of the White Witch though, I can't even figure out where to edit the armor from its passive at all, which means it's probably at the very least unclear if not difficult for the average user to update. Maybe White Witch specifically should have an armor field that you can edit?

OS: Windows 10 Browser: Chrome Foundry version: 11.315 Lancer system version: 2.0.0

[msprijatelj]

@Davis-K-Johnson you would likely edit the Frame item within the mech’s inventory itself, and change its armor appropriately.

I would not make a special case just for the White Witch since there’s already an official system that can raise armor higher than 4 (FORGE-2 Subaltern Squad: Armor Pack). To say nothing of homebrew support!

[sealtrowitz]

you would likely edit the Frame item within the mech’s inventory itself, and change its armor appropriately.

For reference, at least on the current version of the system (1.6.1), editing the Frame item in the mech's inventory to increase the armor value doesn't fully work. It shows as increased on the Frame item, but still caps at 4 on the mech sheet itself. I made an issue about it recently: https://github.com/Eranziel/foundryvtt-lancer/issues/597

[msprijatelj]

That’s good context for the 2.0 branch, then, thank you!