Adonis Script timeout: exhausted allowed execution time

#148 Is still very much an issue! Might be a different function though

May 29 '22 11:05 cl1ents

This is a different error to the one bandaided by Sceleratis. This is a standard script timeout. Do you have any plugins? What is in your settings file?

May 29 '22 11:05 P3tray

This is a different error to the one bandaided by Sceleratis. This is a standard script timeout. Do you have any plugins? What is in your settings file?

It might have to do with the fact that our ban list is insanely big, because the line that errors is this one (We're considering just dumping the ban list in another script)

Edit: we ended up moving said ban list away from the DataStore and into the settings file, we have 2659 bans and that might the the reason why the unpack function chugs.

May 29 '22 11:05 cl1ents

This is a different error to the one bandaided by Sceleratis. This is a standard script timeout. Do you have any plugins? What is in your settings file?

It might have to do with the fact that our ban list is insanely big, because the line that errors is this one (We're considering just dumping the ban list in another script)

Edit: we ended up moving said ban list away from the DataStore and into the settings file, we have 2659 bans and that might the the reason why the unpack function chugs.

I can try to implement a solution today, it might work, it might not. For you, I recommend not banning 2.6k people in the future if you can help it. What the hell? What are you daily player numbers?!

May 29 '22 12:05 P3tray

I am going to try to implement a version of table.unpack which yeilds periodically, possibly even using multithreading. This will be based off the LuaU source code if it's in there, if not I give up.

May 29 '22 12:05 P3tray

Save some people some time in finding it, but it's obviously tasty C code

May 29 '22 13:05 P3tray

https://github.com/Roblox/luau/blob/e06b5c2e28b638d31c091ca9671f0efee3f1ba51/VM/src/lbuiltins.cpp

May 29 '22 13:05 P3tray

@Expertcoderz @Sceleratis @joritochip @Mudock-Yatho If you guys have a better solution to this, let me know.

Do also bear in mind that whatever this does, which I ain't read it properly yet, might not be doing it properly?

May 29 '22 13:05 P3tray

I can try to implement a solution today, it might work, it might not. For you, I recommend not banning 2.6k people in the future if you can help it. What the hell? What are you**(r)** daily player numbers?!

We'll see in the future what that solution gives us, but we have like 4k CCU rn lol

May 29 '22 14:05 cl1ents

tbh I don't think unpack should be having any issue... it's not like it would be unpacking the banlist, just returning the table for it...

May 29 '22 14:05 Sceleratis

Hiya, co-worker of cl1ents here

We mitigated the issue by storing the old banlist we had (the reason this issue is only happening now is because we were moving a ban list over from HD Admin) in a ModuleScript and we just gave it to the settings script instead.

The issue no longer exists. We're happy to implement any future solutions later down the line if they'd be more beneficial.

May 29 '22 14:05 bqsi

tbh I don't think unpack should be having any issue... it's not like it would be unpacking the banlist, just returning the table for it...

I doubt it's unpack, I think it was just the size of the DS. Before I cleared it I realised it was taking up about 12.6% of the allowed storage capacity on any given DS, so it wouldn't surprise me if it was literally just taking a while

May 29 '22 14:05 bqsi

It's still kind of an odd issue, even if it is because of the DataStore being insanely big, why does it decide to not work like in 1/10 cases? Roblox Luau (lowercase u, /ˈlu.aʊ/) quirks??

May 31 '22 06:05 cl1ents

It's still kind of an odd issue, even if it is because of the DataStore being insanely big, why does it decide to not work like in 1/10 cases? Roblox Luau (lowercase u, /ˈlu.aʊ/) quirks??

It's possible that something related to the queue handler stuff in Adonis is looping or yielding in some way that's causing the issue (loop with no wait, basically a crash?)

Even if the datastore has 2k+ records it shouldn't be struggling to handle that. It's a lot for a human but not for modern computing.

May 31 '22 13:05 Sceleratis

https://github.com/Sceleratis/Adonis/issues/788

Jun 12 '22 15:06 Sceleratis

Is this still occurring?

Jun 21 '22 14:06 Expertcoderz

Is this still occurring?

Can confirm this is still occurring in my game, but I have noticed that it is less common (usually 2/3 servers have the issue, previously was near 100%)