Adonis icon indicating copy to clipboard operation
Adonis copied to clipboard

Re-add panic mode

Open ccuser44 opened this issue 7 months ago • 12 comments

I originally removed panic mode in #527 However with fruther thought Adonis panic mode is actually very useful in cases where Adonis fails to load properly. And instead of just failing it still continues the loading process but enables panic mode. This makes Adonis more resilient when bad PRs or something else break Adonis. And more future proof.

ccuser44 avatar May 29 '25 11:05 ccuser44

@Sceleratis @Dimenpsyonal Thoughts?

ccuser44 avatar May 29 '25 11:05 ccuser44

I would like for the formattedchangelog to be made more efficient memory-wise because the client is given a changelog and a formattedchangelog for basically no reason

Dimenpsyonal avatar May 29 '25 12:05 Dimenpsyonal

I would like for the formattedchangelog to be made more efficient memory-wise because the client is given a changelog and a formattedchangelog for basically no reason

Well that shouldn't be a part of this PR

ccuser44 avatar May 29 '25 12:05 ccuser44

and yet there it is

Dimenpsyonal avatar May 29 '25 12:05 Dimenpsyonal

And if we did that Changelog would have to be stored somewhere else than the shared folder because the shared folder is replicated to the client

ccuser44 avatar May 29 '25 12:05 ccuser44

or you could get rid of the formattedchangelog

Dimenpsyonal avatar May 29 '25 12:05 Dimenpsyonal

or you could get rid of the formattedchangelog

Well then the changelog wouldn't be formatted

ccuser44 avatar May 29 '25 12:05 ccuser44

@Dimenpsyonal Pof: PROOFOFWORKPANIC

ccuser44 avatar May 29 '25 12:05 ccuser44

whatever change you made it made the lint fail

Dimenpsyonal avatar Jul 07 '25 09:07 Dimenpsyonal

Adonis should never really fail to load in the first place. It would be a integral flaw if Adonis fails to load, which would be fixed separately. I will let others comment if they have other opinions.

GalacticInspired avatar Nov 12 '25 18:11 GalacticInspired

Fixed conflict with master branch

ccuser44 avatar Nov 22 '25 15:11 ccuser44

Adonis should never really fail to load in the first place. It would be a integral flaw if Adonis fails to load, which would be fixed separately. I will let others comment if they have other opinions.

True. But when Adonis fails to load there is no visual indicator of this happening. It becomes hard to debug to see exactly at which point the error occurs, and you have to dig in the Roblox console to attempt to find the source, if you have access to it in the first place. A loading error in Adonis can occur from many things: Loader script errors, settings file errors, user plugins errors, cloud module download errors, server core module errors, server dependancies errors, server command module errors, server plugin errors, ACLI injection errors, ACLI bootup errors, client module errors, client plugin errors, client theme errors, client remote communication errors, Adonis netcode errors etc. For errors occuring in the server side of the main module this would provide a huge boost in debuggability, ie. immediate feedback instead of waiting a few seconds to see if Adonis just took a bit of time to load (which it sometimes does), with the added bonus of recovering from errors in some cases.

ccuser44 avatar Nov 22 '25 16:11 ccuser44