orion icon indicating copy to clipboard operation
orion copied to clipboard

Revert Subprocess pipe

Open Delaunay opened this issue 1 year ago • 0 comments

Hi there! Thank you for contributing. Feel free to use this pull request template; It helps us reviewing your work at its true value.

Please remove the instructions in italics before posting the pull request :).

Description

Describe what is the purpose of this pull request and why it should be integrated to the repository. When your changes modify the current behavior, explain why your solution is better.

If it solves a GitHub issue, be sure to link it.

Changes

Give an overview of the suggested solution.

Checklist

This is simply a reminder of what we are going to look for before merging your code.

Add an x in the boxes that apply. If you're unsure about any of them, don't hesitate to ask. We're here to help! You can also fill these out after creating the PR if it's a work in progress (be sure to publish the PR as a draft then)

Tests

  • [ ] I added corresponding tests for bug fixes and new features. If possible, the tests fail without the changes
  • [ ] All new and existing tests are passing ($ tox -e py38; replace 38 by your Python version if necessary)

Documentation

  • [ ] I have updated the relevant documentation related to my changes

Quality

  • [ ] I have read the CONTRIBUTING doc
  • [ ] My commits messages follow this format
  • [ ] My code follows the style guidelines ($ tox -e lint)

Further comments

Please include any additional information or comment that you feel will be helpful to the review of this pull request.

Delaunay avatar Aug 17 '22 20:08 Delaunay