orion icon indicating copy to clipboard operation
orion copied to clipboard

Enhance table

Open notoraptor opened this issue 1 year ago • 5 comments

Description

Hi @bouthilx , this is a PR with some enhancements for trials table

Changes

  • Use light gray for empty column headers
  • Allow to display all columns (useful if many columns are hidden) using a checkbox added in multiselect
  • Add drag-and-drop to change columns order
  • Display trial info in a dialog when clicking on trial row

Checklist

Tests

  • [ ] I added corresponding tests for bug fixes and new features. If possible, the tests fail without the changes
  • [ ] All new and existing tests are passing ($ tox -e py38; replace 38 by your Python version if necessary)

Documentation

  • [ ] I have updated the relevant documentation related to my changes

Quality

  • [ ] I have read the CONTRIBUTING doc
  • [ ] My commits messages follow this format
  • [ ] My code follows the style guidelines ($ tox -e lint)

notoraptor avatar Aug 03 '22 07:08 notoraptor

TODO: Use instead a checkbox to "select all"

Put checkbox at top of columns in multiselect component

If all columns are selected, this checkbox should be selected

If any column is deselected, this checkbox should be deselected

notoraptor avatar Aug 03 '22 17:08 notoraptor

Hi @bouthilx ! PR update, I added a checkbox to select all columns, instead of a button. Here is a screencast to show how it works.

Capture d’écran vidéo de 2022-08-05 13:27:45.webm

notoraptor avatar Aug 05 '22 17:08 notoraptor

Finally added drag-and-drop to change column order!

notoraptor avatar Aug 10 '22 12:08 notoraptor

@bouthilx Updated!

  • Display trial info in a dialog when clicking on trial row

notoraptor avatar Aug 12 '22 16:08 notoraptor

PS: We may need a demo to correctly review all changes ^^ !

notoraptor avatar Aug 12 '22 16:08 notoraptor