Aliro icon indicating copy to clipboard operation
Aliro copied to clipboard

base recommender class (base.py) should be abstract

Open hjwilli opened this issue 4 years ago • 1 comments

Indicate that base.py is abstract in some way, perhaps by using the abstract base class module or raising a NotImplementedError if a base instance is instantiated.

(see https://stackoverflow.com/questions/13646245/is-it-possible-to-make-abstract-classes-in-python)

hjwilli avatar May 26 '20 17:05 hjwilli

we could/should add a NotImplementedError in recommend() (here) without a problem. However, most of the base methods are not abstract, they contain baseline shared functionality and are called via super() in derived classes (see here and here for example). We could rename these methods to make the parent methods abstract

lacava avatar May 26 '20 20:05 lacava