proxpi icon indicating copy to clipboard operation
proxpi copied to clipboard

Store local paths as pathlib paths

Open EpicWink opened this issue 1 year ago • 2 comments

Instead of always having the file cache return strings, instead return pathlib.Path instances for local paths, and strings for URLs. This turns the string parsing for URL scheme into simply an isinstance check.

EpicWink avatar Apr 15 '24 10:04 EpicWink

Codecov Report

Attention: Patch coverage is 73.91304% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 89.56%. Comparing base (5afcd9e) to head (e57721e). Report is 1 commits behind head on master.

Files Patch % Lines
src/proxpi/_cache.py 71.42% 6 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   89.45%   89.56%   +0.11%     
==========================================
  Files           3        3              
  Lines         673      661      -12     
==========================================
- Hits          602      592      -10     
+ Misses         71       69       -2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 15 '24 10:04 codecov-commenter

I need to perform benchmarking to see if this increases or reduces latency and server load

EpicWink avatar Apr 17 '24 00:04 EpicWink