ShopChest icon indicating copy to clipboard operation
ShopChest copied to clipboard

Removed shops reappear on reload

Open taifexAI opened this issue 4 years ago • 2 comments

Server version: git-Paper-1618 (MC: 1.12.2)

Plugin version: ShopChest-1.13-SNAPSHOT

Description: Removed shops will reappear if the chests have remained.

Time of occurrence: The server is (re)loading the plugin.

Effect(s):

  • Players may not able to use the chest if it was a shop.
  • Admin shops cannot move their location and change their price at the same time, as the players will abuse them to launder money.

Possible reason(s):

  • The database doesn't remove the shop data when removing a shop.

Temporary solution(s):

  • Commit changes to the database manually to remove the shops.

taifexAI avatar May 13 '20 11:05 taifexAI

I suppose there haven't been any messages somewhere in the console, indicating that the database connection is instable?

EpicEricEE avatar May 13 '20 13:05 EpicEricEE

I suppose there haven't been any messages somewhere in the console, indicating that the database connection is instable?

The console doesn't show any error message when removing shops, even if I enabled the debug log. I forgot to point out that the plugin will show 'No Chest found in world {world} at location: {location}' if the chest isn't there anymore. Therefore, I am pretty sure that the database remains the record of removed shops for some reasons. Although I am facing this problem, the function of creating shops works perfectly. I guess the connection doesn't do a commit to the database when the removal is done?

taifexAI avatar May 25 '20 12:05 taifexAI