pyleecan
pyleecan copied to clipboard
build_geometry method is inconsistent
Hello,
the method build_geometry for the different types of geometry (i.e. Lamination, Slot, ...) is inconsistent, since the input parameter are not the same. Slots build_geometry method has no input parameter for example. At least all build_geometry methods should have the alpha and delta parameter in common.
Best regard, Sebastian
Hello Sebastian,
It is something that bother me also. The issue is that build_geometry for the Lamination and for the Slot are not the same thing. The Lamination one will return the corresponding surface list, the Slot one wil return a list of Line. So maybe the solution is to rename the slot method ? I have no objection to add the alpha and delta parameter to the Slot build_geometry method.
Best regards, Pierre