Enzyme.jl icon indicating copy to clipboard operation
Enzyme.jl copied to clipboard

First stab at nongenabi

Open wsmoses opened this issue 1 year ago • 2 comments

@vchuravy what are your thoughts on a design like this for supporting non-gen abi

wsmoses avatar Jun 26 '24 23:06 wsmoses

In order for code to relocatable you may not observe world as a compile time constant. You may look at the tls_world_age, but you may not cache that or put it into a Val.

vchuravy avatar Jun 27 '24 16:06 vchuravy

Codecov Report

Attention: Patch coverage is 83.09859% with 12 lines in your changes missing coverage. Please review.

Project coverage is 70.35%. Comparing base (d4f44d6) to head (afaacda). Report is 6 commits behind head on main.

Files Patch % Lines
src/Enzyme.jl 78.78% 7 Missing :warning:
src/compiler.jl 77.27% 5 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1575      +/-   ##
==========================================
- Coverage   70.42%   70.35%   -0.07%     
==========================================
  Files          30       30              
  Lines       12754    12788      +34     
==========================================
+ Hits         8982     8997      +15     
- Misses       3772     3791      +19     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jun 28 '24 03:06 codecov-commenter