Enzyme.jl icon indicating copy to clipboard operation
Enzyme.jl copied to clipboard

add fix_inlining

Open vchuravy opened this issue 4 years ago • 3 comments

vchuravy avatar Sep 15 '21 17:09 vchuravy

@wsmoses no idea what this was needed for. So I rescued the code to a branch xD

vchuravy avatar Sep 15 '21 17:09 vchuravy

Yeah basically when enzyme-inline is run Enzyme itself inlines a bunch of stuff for the reverse pass it generates. This results in many different calls to ptls states, sometimes in loops, etc. In case it was an issue this canonicalizes them all together.

wsmoses avatar Sep 15 '21 17:09 wsmoses

Codecov Report

Merging #131 (cf2633d) into master (9513f35) will decrease coverage by 0.76%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
- Coverage   77.03%   76.27%   -0.77%     
==========================================
  Files          12       12              
  Lines        1999     2019      +20     
==========================================
  Hits         1540     1540              
- Misses        459      479      +20     
Impacted Files Coverage Δ
src/compiler.jl 79.86% <0.00%> (-1.35%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9513f35...cf2633d. Read the comment docs.

codecov-commenter avatar Sep 15 '21 18:09 codecov-commenter