Enzo Vezzaro

Results 44 comments of Enzo Vezzaro

yeah, this might be true. I definitely find it uncomfortable having to go to the top left corner of my screen just to "go back" (mostly going home), but it...

> Is this still relevant? I think we can close it Yes, agree. We can close it for now.

We need to make sure to handle all failing calls in order to avoid issues like this. For example: This asset has a NOT working custom provider, this case (like...

> if the user is not connected at all. there's actually another issue on that. Right now, if you're not connected it doesn't calculate the price. I'll take at look...

> that is not an issue, you don't have an infura id in .env Mmmm... I do have this NEXT_PUBLIC_INFURA_PROJECT_ID on my .env file. I'll check again to see if...

> sorry, i just saw that we are on c2d branch , might be a bug , my bad. No worries 😊 Yes, it's not really a bug per se',...

UPDATE: fixed total calculation also as it's wrong too. I see also that it has been fixed in #1715

> This needs a rebase, and there are also some conflicts that popped up after the merge of the compute fixes PR that need to be taken care off ready...

> Is this still relevant, are we using storybook? yes, we're using storybook with testing-library. And working on it in #1480

> To finalize, remove the custom theme toggle button and use the one injected by `storybook-dark-mode` (the moon) Added the toggle button and connected to the theme iFrame, but I'm...