envo icon indicating copy to clipboard operation
envo copied to clipboard

merge landmass and planetary landmass

Open cmungall opened this issue 3 years ago • 4 comments

  • http://purl.obolibrary.org/obo/ENVO_01001782 Landmass: A large continuous area of land, either surrounded by sea or contiguous with another landmass. [ https://en.wiktionary.org/wiki/landmass ]

currently landmass has a single is-a child (planetary landmass) and single part-of child (roadside)

image

landmass already inherits the property of being part-of some astronomical body:

image

So I suppose we might want to retain a class for asteroid landmasses or landmasses of stars. If so siblings should be explicitly populated, and roadside should be migrated to be a part of the more specific planetary landmass (unless we really want to have parallel versions of all structures in ENVO for asteroids and stars)

But really, I think it is good to keep things as simple and possible and remove distinctions that are not useful - merging landmass and planetary landmass is simple and I don't think obstructs any use case for ENVO

I also think landmass/planetary landmass are missing subclasses. See:

  • #1258

cmungall avatar Dec 04 '21 22:12 cmungall

agree. I think its unlikely that the concept of 'land' would be useful on astronomical bodies that do not have water bodies.

smrgeoinfo avatar Dec 06 '21 15:12 smrgeoinfo

The terms definitions are currently:

land

A surface layer of an astronomical body which is primarily composed of solid material and is not covered by oceans or other bodies of water.

landmass

A large continuous area of land, either surrounded by sea or contiguous with another landmass.

I guess there might be an argument for keeping the latter if we can clearly explain the subdivision and why it's different then the parent? I'm not convinced there is a strong differentia here, so I'd be in favor of deprecating the current landmass term, and making landmass the alternative or primary label for the current land class.

kaiiam avatar Aug 10 '22 07:08 kaiiam

land is a mass noun (how many 'lands' doesn't make sense' landmass is an object (how many landmassess' makes better sense)

landmass has constituent 'land'

smrgeoinfo avatar Aug 10 '22 16:08 smrgeoinfo

Thanks @smrgeoinfo

I misread the above Chris was saying

merging landmass and planetary landmass

landmass def:

A large continuous area of land, either surrounded by sea or contiguous with another landmass.

planetary landmass def:

A landmass which is part of a planet.

As @smrgeoinfo alluded to earlier if landmasses are always on a planet then there would be no need for planetary landmass. Is that always true?

kaiiam avatar Aug 10 '22 18:08 kaiiam