envo icon indicating copy to clipboard operation
envo copied to clipboard

Add comment to 'eaves' describing function?

Open johnwjudkins opened this issue 5 years ago • 7 comments

The VEuPath ontology team has decided to replace our 'eaves' class with ENVO's. We agree with the ENVO definition, but the VEuPath definition contains an additional description of the function of eaves that we think is helpful to users:

"The primary function of the eaves is to keep rain water off the walls and to prevent the ingress of water at the junction where the roof meets the wall. The secondary function is to control solar penetration; the eaves overhang can be designed to adjust the building's solar heat gain to suit the local climate, the latitude and orientation of the building, refer to passive solar building design. The eaves overhang may also shelter openings to ventilate the roof space."

Would you be interested in adding this description to this class as a comment?

johnwjudkins avatar Sep 17 '20 20:09 johnwjudkins

I think this is good information to put in a comment. We should also consider including in the information in the definition (which is currently has the annotation property 'has_narrrow_synonym').

wdduncan avatar Sep 24 '20 13:09 wdduncan

This class still has its definition under has_narrow_synonym as of the latest release.

johnwjudkins avatar Mar 30 '22 13:03 johnwjudkins

@johnwjudkins Are you able to make a PR with the information as a comment?

wdduncan avatar Mar 30 '22 14:03 wdduncan

@wdduncan Can you give me write access? Then I'll make a PR and link here.

johnwjudkins avatar Mar 30 '22 20:03 johnwjudkins

@johnwjudkins I just gave you "Triage" permissions. It should allow you to make a PR.

wdduncan avatar Mar 30 '22 20:03 wdduncan

@wdduncan I accepted the invitation but still cannot publish a branch or make a PR (even after re-cloning the repo).

johnwjudkins avatar Mar 31 '22 15:03 johnwjudkins

@johnwjudkins I just gave you write permissions. Let's see if that works.

wdduncan avatar Mar 31 '22 15:03 wdduncan