Ghost icon indicating copy to clipboard operation
Ghost copied to clipboard

Add new ui and new installation

Open MoDarK-MK opened this issue 2 months ago • 76 comments

Screenshot_2025-10-16_09_30_55 Screenshot_2025-10-16_09_30_41

MoDarK-MK avatar Oct 16 '25 13:10 MoDarK-MK

Hello I hope you are well This is my update for a better look and easier installation If you like you can add it Thank you

MoDarK-MK avatar Oct 16 '25 13:10 MoDarK-MK

Also in this case we have traceback

MoDarK-MK avatar Oct 16 '25 13:10 MoDarK-MK

if you like this tell me to code more

MoDarK-MK avatar Oct 16 '25 13:10 MoDarK-MK

@enty8080 can you give a look to this please? Also, the project needs to have at least requirements.txt file as in this PR or a pyproject.toml file instead of the setup.py.

D3vil0p3r avatar Oct 17 '25 17:10 D3vil0p3r

Hi, I hope you are well I will look into it and send you the result Thank you I will send you all the updates for this tool

MoDarK-MK avatar Oct 17 '25 17:10 MoDarK-MK

Hello again I did some things to make the tool better

MoDarK-MK avatar Oct 17 '25 21:10 MoDarK-MK

Hello again I did some things to make the tool better

Can you standardize it by using pyproject.toml approach instead of install.py?

D3vil0p3r avatar Oct 17 '25 21:10 D3vil0p3r

Hello, @MoDarK-MK

I will review your code as soon as I can.

Regards, Ivan Nikolskiy (@enty8080)

enty8080 avatar Oct 17 '25 21:10 enty8080

Hello, @MoDarK-MK

I will review your code as soon as I can.

Regards, Ivan Nikolskiy (@enty8080)

Sorry if I mention it again: I would like to package Ghost for BlackArch. Could you please also deploy it by replacing setup.py/install.py with pyproject.toml? It is for standardize and modernize your Python project and it simplifies a lot the creation of an Arch Linux package of this tool. Thanks a lot.

D3vil0p3r avatar Oct 17 '25 21:10 D3vil0p3r

ye its ok man i love coding what ever you want thanks

MoDarK-MK avatar Oct 17 '25 21:10 MoDarK-MK

I do it for you with love

MoDarK-MK avatar Oct 17 '25 21:10 MoDarK-MK

You are the guy any organization should have

D3vil0p3r avatar Oct 17 '25 21:10 D3vil0p3r

i think its ok now can you check?

MoDarK-MK avatar Oct 17 '25 21:10 MoDarK-MK

Yes. I need just to end some stuff with Microsoft, and I will quickly test your branch

D3vil0p3r avatar Oct 17 '25 22:10 D3vil0p3r

@MoDarK-MK I did some checks. First question: on pyproject.toml, you wrote:

[project.scripts]
ghost = "ghost:main"

but main.py does not exist. It seems that the entry point is ghost/__init__.py. Should that part of pyproject.toml changed as well?

Second question: after the installation, when I run ghost, I get:

Traceback (most recent call last):
  File "/usr/share/ghost/ghost/__init__.py", line 25, in <module>
    from ghost.core.console import Console
  File "/usr/share/ghost/venv/lib/python3.13/site-packages/ghost/__init__.py", line 25, in <module>
    from ghost.core.console import Console
  File "/usr/share/ghost/venv/lib/python3.13/site-packages/ghost/core/console.py", line 25, in <module>
    from badges.cmd import Cmd
ModuleNotFoundError: No module named 'badges'

In pyproject.toml is labelled as optional. At this point I think it is mandatory so it should be moved under dependencies. What do you think?

D3vil0p3r avatar Oct 17 '25 23:10 D3vil0p3r

@MoDarK-MK I don't have pyproject.toml on main branch and never had any.

enty8080 avatar Oct 17 '25 23:10 enty8080

for this problem (badges) you nead to download it and change some code to can run ghost if you want i can attach a video

MoDarK-MK avatar Oct 17 '25 23:10 MoDarK-MK

@MoDarK-MK I don't have pyproject.toml on main branch and never had any.

pyproject.toml is now the modern, standardized way to define Python projects. It has effectively replaced setup.py and setup.cfg for most new Python packages.

setup.py is phase out and it will be deprecated.

D3vil0p3r avatar Oct 17 '25 23:10 D3vil0p3r

@MoDarK-MK I don't have pyproject.toml on main branch and never had any.

yes it is D3vil0p3r tell me

MoDarK-MK avatar Oct 17 '25 23:10 MoDarK-MK

@enty8080 I have a pull request badges project , please add it so that the tool works properly.

MoDarK-MK avatar Oct 17 '25 23:10 MoDarK-MK

@MoDarK-MK I don't have pyproject.toml on main branch and never had any.

yes it is D3vil0p3r tell me

No there is no pyproject.toml in original branch, please check again.

enty8080 avatar Oct 17 '25 23:10 enty8080

@MoDarK-MK I don't have pyproject.toml on main branch and never had any.

yes it is D3vil0p3r tell me

No there is no pyproject.toml in original branch, please check again.

We are aware it is not in the original branch. @MoDarK-MK added it in this PR to renovate and modernize the project. The original branch has the old and phased out setup.py.

D3vil0p3r avatar Oct 17 '25 23:10 D3vil0p3r

its good update isnt it?

MoDarK-MK avatar Oct 17 '25 23:10 MoDarK-MK

@MoDarK-MK

I am glad you are interested in my work and tools, however I am afraid I would not be able to accept this pull request or any pull request that changes codebase or related libraries severely. There are several reasons for this:

  1. Other projects depend on libraries and if altered only for a single project, they might stop working
  2. All EntySec tools follow a standardized code style and CLI style (interface) that should not be changed

I appreciate your contribution to the project, however I am afraid it can't go to the original branch. I suggest you to continue working on it but as on a separate fork. Keep up great work!

This decision is non-disputable.

Regards, Ivan Nikolskiy

enty8080 avatar Oct 17 '25 23:10 enty8080

I understand your point @enty8080 , but the change to pyproject.toml does not affect other related projects. It follows the official standard: https://packaging.python.org/en/latest/specifications/pyproject-toml/ <-- Official Python website.

Regardless, setup.py should eventually be dropped. Also, the current Ghost codebase does not include a requirements.txt file, which was traditionally used alongside setup.py. When deprecated, it could introduce security flaws, just to say.

Interoperability is not a concern here.

D3vil0p3r avatar Oct 17 '25 23:10 D3vil0p3r

this is the END

MoDarK-MK avatar Oct 17 '25 23:10 MoDarK-MK

Ja... I don't agree with that rationale, or better, that fear, but... we are all humans.

D3vil0p3r avatar Oct 17 '25 23:10 D3vil0p3r

Love you Guys

MoDarK-MK avatar Oct 17 '25 23:10 MoDarK-MK

@MoDarK-MK @D3vil0p3r What's the problem with having it as a fork?

enty8080 avatar Oct 17 '25 23:10 enty8080

nothing i just try to make somthing lovely its your project its your rules

MoDarK-MK avatar Oct 17 '25 23:10 MoDarK-MK