Results 162 comments of Andrew Dodd

I could use some input on some oddities I discovered, there seem to be multiple comment types, and I question the validity of some of them: The `default` file starts...

Will have to do a deep-dive on that, // comments would create a mismatch, but I'll need to read through multilangmgr to figure out why this didn't break: ``` /*...

https://github.com/Beep6581/RawTherapee/blob/b1e7860a234109761fb9e693e0c603cf0c58827f/rtgui/multilangmgr.cc#L201 If I'm reading that and https://www.cplusplus.com/reference/map/map/emplace_hint/ is correct (insertion only happens if the key is not already present), I think we're probably going to see some wrong behaviors. Time...

That's what I suspected might happen, you confirmed it before I could get to that point in the UI. :) It's a lot easier to fix a bug when you...

@Desmis - the issue as far as mistakes is that when someone (you?) tried to remove them, they used C-style block comments (/* and */) which are not actually valid...

looks like it can't find grep? Path issue combined with python's subprocess possibly?

Since it's just a developer support tool, feel free to skip merging for 5.9 unless you want to rerun it for further sanity checks while I'm away. I'll try to...

generateTranslationDiffs was on my list of things to do after my pull request was done. Will try and take a look at this tonight too.

@Lawrence37 I just tried running generateTranslationDiffs against the results of my cleanup and I'm not seeing it delete FILEBROWSER_POPUPRANK0