PyFunctional icon indicating copy to clipboard operation
PyFunctional copied to clipboard

Add typing, some refactor, run and fix all doctests

Open artemisart opened this issue 1 year ago • 1 comments

  • type type type many things
  • doctests were not run ! fixed all doctests, there were many errors
  • make outer join follow the input ordering (avoids sets)
  • factorise & reuse some methods -> we can remove the implementation of distinct, select, where, order_by, flatten, zip_with_index, init
  • remove PRE_COMPUTE by doing the lists in the functions where needed
  • simplify some counters, group by operations
  • fix some exception types (ValueError that should be TypeError, ...)

TODO potential improvement: improve typing on _wrap returns like __getitem__

artemisart avatar Feb 03 '24 11:02 artemisart

Don't you think the changes in this might be too much to push all at once?

maestro-1 avatar Feb 23 '24 10:02 maestro-1