barman icon indicating copy to clipboard operation
barman copied to clipboard

Add aws irsa auth

Open smcaine opened this issue 1 year ago • 4 comments

Adding this flag to use the service account iam role, for when using eks: https://docs.aws.amazon.com/eks/latest/userguide/iam-roles-for-service-accounts-minimum-sdk.html

Using aws access keys is bad practice and typically prohibited in most production environments.

This relates to issue i raised https://github.com/EnterpriseDB/barman/issues/949

smcaine avatar Oct 09 '24 10:10 smcaine

@smcaine thanks for your contribution.

I've put a suggestion in the code during my review of the pr.

The code seems correct but your patch has broken the Unit Tests for Barman, because of this we cannot merge the PR as it is.

Could you fix the failing tests? Would also be of help for you to add some specific Unit Tests for the code you introduced.

FYI we are working on some contribution guidelines for PRs and what I'm asking will be part of this new documentation section.

Thanks.

gcalacoci avatar Nov 05 '24 09:11 gcalacoci

Hi Stuart, as mentioned before, your PR is failing for tox tests. Can you check these and push a fix that makes them pass?

https://github.com/EnterpriseDB/barman/actions/runs/11720727101/job/32805402247?pr=1021

There are also flack errors that need addressing:

https://github.com/EnterpriseDB/barman/actions/runs/11720727101/job/32805400982?pr=1021

martinmarques avatar Nov 18 '24 16:11 martinmarques

Hi Stuart, as mentioned before, your PR is failing for tox tests. Can you check these and push a fix that makes them pass?

https://github.com/EnterpriseDB/barman/actions/runs/11720727101/job/32805402247?pr=1021

There are also flack errors that need addressing:

https://github.com/EnterpriseDB/barman/actions/runs/11720727101/job/32805400982?pr=1021

yes, apologies, i have not been able to pick this up, will start running through these and add tests for the work done in the PR

smcaine avatar Dec 04 '24 14:12 smcaine

Can these tests be re-run? Hopefully I've covered everything. Ive just revised PR so its clear this is just for EKS and IAM role Service accounts

smcaine avatar Dec 09 '24 11:12 smcaine