eAPD icon indicating copy to clipboard operation
eAPD copied to clipboard

removed unneeded user data

Open thetif opened this issue 2 years ago • 4 comments

Resolves PIA concerns

Description

Our application was keeping a lot of user data that we weren't using that could be considered PII. We decided to remove this information to remove all possible PII.

Significant changes or possible side effects

This will affect adding State Certificates, State Admin Dashboard, and Federal Admin Dashboard.

Steps to manually verify this change

  1. Login as Federal Admin
  2. Confirm that you can view data on all of the tabs
  3. Confirm that you can add a State Certificate
  4. Logout
  5. Login as a State Admin
  6. Confirm that you can view data on all of the tabs
  7. Confirm that clicking on Approve, Revoke, Restore opens modals and doesn't contain phone numbers.
  8. Generally confirm that the only phone number in the system belongs to the Key State Personnel

This pull request is ready to code review when

  • [x] Automated tests are updated (and all tests are passing)
  • [x] Associated OpenAPI documentation has been updated

This pull request is ready to test when

  • [ ] Code has been reviewed by someone other than the original author

This pull request is ready to review when the QA has

  • [ ] Verified the functionality related to the change
  • [ ] Verified that the change works with Narrator on Windows
  • [ ] Verified that the change works with VoiceOver on Mac
  • [ ] Verified all updated pages with the WAVE tool
  • [ ] Verified tab and keyboard navigation functionality

This pull request can be merged when

  • [ ] Design has approved the experience
  • [ ] Product has approved the experience

thetif avatar Oct 18 '22 19:10 thetif

Codecov Report

Merging #4370 (b9f1fb2) into main (6fb5262) will increase coverage by 0.01%. The diff coverage is 100.00%.

:exclamation: Current head b9f1fb2 differs from pull request most recent head 9913c50. Consider uploading reports for the commit 9913c50 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4370      +/-   ##
==========================================
+ Coverage   85.97%   85.98%   +0.01%     
==========================================
  Files         263      263              
  Lines        6040     6038       -2     
  Branches     1288     1287       -1     
==========================================
- Hits         5193     5192       -1     
+ Misses        784      783       -1     
  Partials       63       63              
Impacted Files Coverage Δ
api/db/affiliations.js 60.00% <ø> (ø)
api/db/certifications.js 63.33% <ø> (ø)
api/db/users.js 100.00% <ø> (ø)
web/src/pages/admin/ManageRoleDialog.js 84.84% <ø> (ø)
...rc/pages/admin/fed-admin/DelegateStateAdminForm.js 66.66% <ø> (+0.75%) :arrow_up:
...b/src/pages/admin/fed-admin/ManageAllUsersTable.js 91.11% <ø> (ø)
...src/pages/admin/fed-admin/MatchStateAdminDialog.js 79.31% <ø> (ø)
web/src/pages/admin/fed-admin/StateAdminLetters.js 49.09% <ø> (ø)
web/src/pages/admin/state-admin/ManageUserTable.js 100.00% <ø> (ø)
api/db/oktaUsers.js 93.93% <100.00%> (ø)
... and 2 more

Impacted file tree graph

Impacted Files Coverage Δ
api/db/affiliations.js 60.00% <ø> (ø)
api/db/certifications.js 63.33% <ø> (ø)
api/db/users.js 100.00% <ø> (ø)
web/src/pages/admin/ManageRoleDialog.js 84.84% <ø> (ø)
...rc/pages/admin/fed-admin/DelegateStateAdminForm.js 66.66% <ø> (+0.75%) :arrow_up:
...b/src/pages/admin/fed-admin/ManageAllUsersTable.js 91.11% <ø> (ø)
...src/pages/admin/fed-admin/MatchStateAdminDialog.js 79.31% <ø> (ø)
web/src/pages/admin/fed-admin/StateAdminLetters.js 49.09% <ø> (ø)
web/src/pages/admin/state-admin/ManageUserTable.js 100.00% <ø> (ø)
api/db/oktaUsers.js 93.93% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6fb5262...9913c50. Read the comment docs.

codecov-commenter avatar Oct 18 '22 20:10 codecov-commenter

This deploy was cleaned up.

cms-eapd-bot avatar Oct 18 '22 21:10 cms-eapd-bot

@thetif @mirano-darren I can't access the state admin dashboard when logging in as the state admin (as Alaska). Not sure if that's tied to this PR, but it's working in Staging.

jeromeleecms avatar Oct 20 '22 17:10 jeromeleecms

You have to use [email protected], it works in staging because I manually set it up. I have a ticket to fix the seeder, but we haven't had time yet.

thetif avatar Oct 20 '22 17:10 thetif