eAPD icon indicating copy to clipboard operation
eAPD copied to clipboard

Tbolt/4214 admin check integration

Open tbolt opened this issue 2 years ago • 2 comments

Resolves #4212

Description

Integrates backend admin check work with front end work completing the admin check feature

Significant changes or possible side effects

Updates admin check panel to use real data vs. mocked Added new feature flag

This pull request is ready to code review when

  • [x] Automated tests are updated (and all tests are passing)
  • [ ] New automated test cases are documented above
  • [x] Pull request has been labeled, if applicable with feature, content, bug, tests, refactor
  • [ ] Associated OpenAPI documentation has been updated
  • [x] The experience passes a basic manual accessibility audit (keyboard nav, screenreader, text scaling) OR an exemption is documented

This pull request is ready to test when

  • [ ] Code has been reviewed by someone other than the original author

This pull request is ready to review when the QA has

  • [ ] Verified the functionality related to the change
  • [ ] Verified that the change works with Narrator on Windows
  • [ ] Verified that the change works with VoiceOver on Mac
  • [ ] Verified all updated pages with the WAVE tool
  • [ ] Verified tab and keyboard navigation functionality

This pull request can be merged when

  • [ ] Design has approved the experience
  • [ ] Product has approved the experience

tbolt avatar Oct 14 '22 11:10 tbolt

Codecov Report

Merging #4359 (d84ea6b) into tbolt/3676-admin-check-drawer (2501191) will decrease coverage by 0.79%. The diff coverage is 83.58%.

Impacted file tree graph

@@                        Coverage Diff                        @@
##           tbolt/3676-admin-check-drawer    #4359      +/-   ##
=================================================================
- Coverage                          86.13%   85.33%   -0.80%     
=================================================================
  Files                                265      265              
  Lines                               6137     6159      +22     
  Branches                            1317     1316       -1     
=================================================================
- Hits                                5286     5256      -30     
- Misses                               787      840      +53     
+ Partials                              64       63       -1     
Impacted Files Coverage Δ
api/db/apds.js 24.65% <0.00%> (-61.83%) :arrow_down:
web/src/components/AdminCheckPanel.js 90.24% <ø> (-0.24%) :arrow_down:
...vities/activities-dashboard/ActivitiesDashboard.js 100.00% <ø> (ø)
...ies/cost-allocation/CostAllocation/CostAllocate.js 86.36% <ø> (ø)
...eb/src/pages/apd/activities/ffp/CostAllocateFFP.js 92.06% <ø> (-1.59%) :arrow_down:
...w/NameAndFundingSource/NameAndFundingSourceForm.js 59.25% <ø> (ø)
web/src/pages/apd/activities/overview/Overview.js 87.50% <ø> (ø)
web/src/pages/apd/activities/overview/Schedule.js 56.66% <ø> (ø)
.../apd/activities/overview/StandardsAndConditions.js 78.26% <ø> (ø)
...y-state-personnel/ApdStateProfileMedicaidOffice.js 38.59% <ø> (ø)
... and 21 more

Impacted file tree graph

Impacted Files Coverage Δ
api/db/apds.js 24.65% <0.00%> (-61.83%) :arrow_down:
web/src/components/AdminCheckPanel.js 90.24% <ø> (-0.24%) :arrow_down:
...vities/activities-dashboard/ActivitiesDashboard.js 100.00% <ø> (ø)
...ies/cost-allocation/CostAllocation/CostAllocate.js 86.36% <ø> (ø)
...eb/src/pages/apd/activities/ffp/CostAllocateFFP.js 92.06% <ø> (-1.59%) :arrow_down:
...w/NameAndFundingSource/NameAndFundingSourceForm.js 59.25% <ø> (ø)
web/src/pages/apd/activities/overview/Overview.js 87.50% <ø> (ø)
web/src/pages/apd/activities/overview/Schedule.js 56.66% <ø> (ø)
.../apd/activities/overview/StandardsAndConditions.js 78.26% <ø> (ø)
...y-state-personnel/ApdStateProfileMedicaidOffice.js 38.59% <ø> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2501191...d84ea6b. Read the comment docs.

codecov-commenter avatar Oct 14 '22 17:10 codecov-commenter

This deploy was cleaned up.

cms-eapd-bot avatar Oct 14 '22 18:10 cms-eapd-bot