Nz/4209 new apd page

[Sun-Mountain]

Resolves #

Description

Significant changes or possible side effects

Automated test cases written

Given	When	Then	Type (jest, tap, cypress)

Steps to manually verify this change

This pull request is ready to code review when

• [ ] Automated tests are updated (and all tests are passing)
• [ ] New automated test cases are documented above
• [ ] Pull request has been labeled, if applicable with feature, content, bug, tests, refactor
• [ ] Associated OpenAPI documentation has been updated
• [ ] The experience passes a basic manual accessibility audit (keyboard nav, screenreader, text scaling) OR an exemption is documented

This pull request is ready to test when

• [ ] Code has been reviewed by someone other than the original author

This pull request is ready to review when the QA has

• [ ] Verified the functionality related to the change
• [ ] Verified that the change works with Narrator on Windows
• [ ] Verified that the change works with VoiceOver on Mac
• [ ] Verified all updated pages with the WAVE tool
• [ ] Verified tab and keyboard navigation functionality

This pull request can be merged when

• [ ] Design has approved the experience
• [ ] Product has approved the experience

[codecov-commenter]

Codecov Report

Merging #4335 (d71f788) into main (0c404f8) will decrease coverage by 0.56%. The diff coverage is 97.65%.

@@            Coverage Diff             @@
##             main    #4335      +/-   ##
==========================================
- Coverage   95.04%   94.48%   -0.57%     
==========================================
  Files         313      314       +1     
  Lines        6860     6978     +118     
  Branches     1505     1526      +21     
==========================================
+ Hits         6520     6593      +73     
- Misses        334      374      +40     
- Partials        6       11       +5     

Impacted Files	Coverage Δ
web/src/pages/mainRoutesList.js	100.00% <ø> (ø)
web/src/pages/apd/apd-overview/ApdOverview.js	94.59% <75.00%> (-5.41%)	:arrow_down:
web/src/pages/apd/new/ApdNew.js	99.08% <99.08%> (ø)
api/db/apds.js	92.59% <100.00%> (+0.06%)	:arrow_up:
web/src/layout/header/ApdHeader.js	93.10% <100.00%> (ø)
web/src/layout/header/Header.js	98.07% <100.00%> (+0.07%)	:arrow_up:
web/src/pages/dashboard/state-dashboard/ApdList.js	97.29% <100.00%> (-0.21%)	:arrow_down:
web/src/redux/actions/app/apd.js	98.98% <100.00%> (+0.01%)	:arrow_up:
...y-state-personnel/ApdStateProfileMedicaidOffice.js	59.64% <0.00%> (-29.83%)	:arrow_down:
...apd/activities/schedule-and-milestones/Schedule.js	74.19% <0.00%> (-19.36%)	:arrow_down:
... and 7 more

Impacted Files	Coverage Δ
web/src/pages/mainRoutesList.js	100.00% <ø> (ø)
web/src/pages/apd/apd-overview/ApdOverview.js	94.59% <75.00%> (-5.41%)	:arrow_down:
web/src/pages/apd/new/ApdNew.js	99.08% <99.08%> (ø)
api/db/apds.js	92.59% <100.00%> (+0.06%)	:arrow_up:
web/src/layout/header/ApdHeader.js	93.10% <100.00%> (ø)
web/src/layout/header/Header.js	98.07% <100.00%> (+0.07%)	:arrow_up:
web/src/pages/dashboard/state-dashboard/ApdList.js	97.29% <100.00%> (-0.21%)	:arrow_down:
web/src/redux/actions/app/apd.js	98.98% <100.00%> (+0.01%)	:arrow_up:
...y-state-personnel/ApdStateProfileMedicaidOffice.js	59.64% <0.00%> (-29.83%)	:arrow_down:
...apd/activities/schedule-and-milestones/Schedule.js	74.19% <0.00%> (-19.36%)	:arrow_down:
... and 7 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0c404f8...d71f788. Read the comment docs.

[cms-eapd-bot]

See this pull request in action: https://ec2-3-213-107-82.compute-1.amazonaws.com

d71f7883319e41495f42e6e90adfdafeb8d49f84

[thetif]

looks great! thanks for the persistence!

[tbolt]

Looks good, approved and ready to be moved to ready for review ✅

• Tested featureFlag - Turning it off made it so HITECH is automatically selected and only option as expected ✅
• Tested selected all FFYs and all Update Type - ✅
• Tested not adding a APD name for HITECH and MMIS - ✅
• Tested MMIS with all options selected - ✅
• Tested MMIS with a mix of options selected - ✅
• Tested HITECH with all options selected - ✅
• Tested HITECH with mix of options selected - ✅
• Accessibility - Tested briefly with VoiceOver, no issues noted ✅
• Accessibility - Ran axe DevTools - No issues found ✅

[mirano-darren]

Looks good to me also, nice work kicking off our MMIS work! 🎉 Test Cases: Validation:

Given	When	Then	Result
APD Type field	on-blur	This field is required and cannot be blank. Should have inline validation with the error message: Select an APD Type	✅
Is this APD an Update? field	on-blur	This field is required and cannot be blank. Should have inline validation with the error message: Indicate whether this APD is an update.	✅
Medicaid Business Areas field	on-blur	This field is required and cannot be blank. Should have inline validation with the error message: Select at least one Medicaid Business Area.	🟨
create APD page	At least one field is left blank	Create an APD button should be unclickable, grayed out, and have a tooltip on hover. The tooltip should have the language: All fields are required to create an APD.	✅
Is this APD an update? field	user selects "Yes this is an update"	Subsection should appear asking if the update is a Annual update or an As needed update. If left blank it should have the validation error message: Select an update type.	✅
Medicaid Business Areas field	user selects "Other" as an option	A textbox should appear asking the user to document the other business area. If this field is left blank, it should have the validation error message: Provide an other Medicaid Business Area(s)	✅

When creating a new APD:

Given	When	Then	Result
APD Dashboard	user clicks the Create New button	Should redirect the user to the new create APD page	✅
Create APD page	user chooses to create a HITECH APD	page should not include Medicaid Business Areas	✅
Create APD page	user chooses to create an MMIS APD	page should include Medicaid Business Areas	✅
A filled out create APD page, HITECH selected	user clicks the Create APD button	Should redirect to the normal HITECH APD builder; APD Overview	✅
A filled out create APD page, MMIS selected	user clicks the Create APD button	Should redirect to the normal HITECH APD builder; APD Overview	✅
create APD page	user clicks the Cancel button	Should close the page, redirect to the APD dashboard and no APD should be added to the dashboard.	✅
APD Type field	user is choosing between HITECH or MMIS	Both selections should have help text explaining each type underneath. HITECH tooltip: Health Information Technology for Economic and Clinical Health Implementation APD. MMIS tooltip: Medicaid Management Information System Implementation APD	✅
Create new APD page	MMIS IAPD feature flag is turned off	MMIS IAPD should not be listed as an option in APD type	✅
Create new APD page	MMIS IAPD feature flag is turned on	MMIS IAPD should be listed as an option in APD type	✅

One small validation language issue. Still approving the PR b/c I don't want this one small issue to bottleneck this merge: Medicaid Business Areas has the validation error message for the Other text box. It should be: Select at least one Medicaid Business Area.

[akuas]

For the scope of this ticket, this looks good! Im assuming for the ticket dealing with the APD Overview, the field name would be added to the HITECH and MMIS options and the tooltip will go away.