eAPD icon indicating copy to clipboard operation
eAPD copied to clipboard

Tbolt/2738 Enhancements to session timeout alert to increase accessibility

Open tbolt opened this issue 2 years ago • 3 comments

Resolves #2738

Description

Updates the session timeout alert to only change on the minute vs. every second. Each change is displayed in the dialog and announced to the screen reader. At 1 minute the message reflects a slightly different message stating "less than 1 minute."

Significant changes or possible side effects

Shouldn't impact anything outside of the alert dialog

Automated test cases written

Given When Then Type (jest, tap, cypress)
Logged in idle for 10 minutes alert shows message that 5 minutes remain before logout jest
Logged in idle for 14 minutes alert shows message that less than 1 minute remains before logout jest

Steps to manually verify this change

Note: A screen reader will need to be used to fully test this

  1. Login and open an APD
  2. Idle for 10+ minutes
  3. Verify alert is shown. Verify message is read to screen reader at each minute mark
  4. Verify logout is executed after the timeout. Verify message is read to screen reader

This pull request is ready to code review when

  • [x] Automated tests are updated (and all tests are passing)
  • [x] New automated test cases are documented above
  • [x] Pull request has been labeled, if applicable with feature, content, bug, tests, refactor
  • [x] Associated OpenAPI documentation has been updated
  • [x] The experience passes a basic manual accessibility audit (keyboard nav, screenreader, text scaling) OR an exemption is documented

This pull request is ready to test when

  • [x] Code has been reviewed by someone other than the original author

This pull request is ready to review when the QA has

  • [ ] Verified the functionality related to the change
  • [ ] Verified that the change works with Narrator on Windows
  • [ ] Verified that the change works with VoiceOver on Mac
  • [ ] Verified all updated pages with the WAVE tool
  • [ ] Verified tab and keyboard navigation functionality

This pull request can be merged when

  • [ ] Design has approved the experience
  • [ ] Product has approved the experience

tbolt avatar Sep 07 '22 14:09 tbolt

Codecov Report

Merging #4305 (7ae99e6) into main (b07e45f) will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4305      +/-   ##
==========================================
+ Coverage   94.25%   94.27%   +0.01%     
==========================================
  Files         252      252              
  Lines        7762     7768       +6     
  Branches     1671     1673       +2     
==========================================
+ Hits         7316     7323       +7     
+ Misses        427      426       -1     
  Partials       19       19              
Impacted Files Coverage Δ
web/src/components/SessionEndingAlert.js 96.42% <100.00%> (+5.12%) :arrow_up:
web/src/pages/login/LoginForm.js 96.00% <100.00%> (+0.16%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b07e45f...7ae99e6. Read the comment docs.

codecov-commenter avatar Sep 07 '22 14:09 codecov-commenter

See this pull request in action: https://ec2-3-213-107-82.compute-1.amazonaws.com

7ae99e6e905cce47b49cdd8fd9e7e715bdd7b81f

cms-eapd-bot avatar Sep 07 '22 15:09 cms-eapd-bot

@tbolt will re-review this 09/29

jeromeleecms avatar Sep 29 '22 17:09 jeromeleecms