eAPD icon indicating copy to clipboard operation
eAPD copied to clipboard

Dmirano/4238 cypress budget checks

Open mirano-darren opened this issue 2 years ago • 2 comments

Resolves #4238

Description

Adds Cypress tests to check the budget calculations.

Significant changes or possible side effects

Adds the test suite to the circle config

Automated test cases written

04-budget-checks

Steps to manually verify this change

  1. Verify test runs and passes in circle

This pull request is ready to review when

  • [ ] Automated tests are updated (and all tests are passing)
  • [ ] Pull request has been labeled, if applicable with feature, content, bug, tests, refactor
  • [ ] Associated OpenAPI documentation has been updated
  • [ ] The experience passes a basic manual accessibility audit (keyboard nav, screenreader, text scaling) OR an exemption is documented

This pull request can be merged when

  • [ ] Code has been reviewed by someone other than the original author
  • [ ] QA has verified the functionality related to the change
  • [ ] QA has verified the accessibility using tools such as screen readers and WAVE (accessibility evaluation tool)
  • [ ] Design has approved the experience
  • [ ] Product has approved the experience

mirano-darren avatar Aug 26 '22 19:08 mirano-darren

Codecov Report

Merging #4284 (7c5b2cb) into main (d9d4ad2) will increase coverage by 0.07%. The diff coverage is n/a.

:exclamation: Current head 7c5b2cb differs from pull request most recent head 6ca9354. Consider uploading reports for the commit 6ca9354 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4284      +/-   ##
==========================================
+ Coverage   86.30%   86.38%   +0.07%     
==========================================
  Files         260      260              
  Lines        5931     5906      -25     
  Branches     1240     1230      -10     
==========================================
- Hits         5119     5102      -17     
+ Misses        752      745       -7     
+ Partials       60       59       -1     
Impacted Files Coverage Δ
web/src/components/Instruction.js 96.77% <0.00%> (-3.23%) :arrow_down:
...ies/cost-allocation/CostAllocation/OtherFunding.js 60.00% <0.00%> (-1.12%) :arrow_down:
web/src/redux/actions/aria.js 100.00% <0.00%> (ø)
web/src/components/RichText.js 80.88% <0.00%> (ø)
web/src/pages/apd/apd-overview/ApdOverview.js 85.71% <0.00%> (ø)
web/src/pages/admin/fed-admin/StateAdminLetters.js 49.09% <0.00%> (ø)
...ages/apd/previous-activities/PreviousActivities.js 100.00% <0.00%> (ø)
.../apd/activities/overview/StandardsAndConditions.js 76.19% <0.00%> (ø)
...costs/ContractorResource/ContractorResourceForm.js 87.14% <0.00%> (ø)
api/db/apds.js 94.82% <0.00%> (+0.18%) :arrow_up:
... and 3 more

Impacted file tree graph

Impacted Files Coverage Δ
web/src/components/Instruction.js 96.77% <0.00%> (-3.23%) :arrow_down:
...ies/cost-allocation/CostAllocation/OtherFunding.js 60.00% <0.00%> (-1.12%) :arrow_down:
web/src/redux/actions/aria.js 100.00% <0.00%> (ø)
web/src/components/RichText.js 80.88% <0.00%> (ø)
web/src/pages/apd/apd-overview/ApdOverview.js 85.71% <0.00%> (ø)
web/src/pages/admin/fed-admin/StateAdminLetters.js 49.09% <0.00%> (ø)
...ages/apd/previous-activities/PreviousActivities.js 100.00% <0.00%> (ø)
.../apd/activities/overview/StandardsAndConditions.js 76.19% <0.00%> (ø)
...costs/ContractorResource/ContractorResourceForm.js 87.14% <0.00%> (ø)
api/db/apds.js 94.82% <0.00%> (+0.18%) :arrow_up:
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d9d4ad2...6ca9354. Read the comment docs.

codecov-commenter avatar Aug 26 '22 19:08 codecov-commenter

This deploy was cleaned up.

cms-eapd-bot avatar Aug 26 '22 19:08 cms-eapd-bot