eAPD icon indicating copy to clipboard operation
eAPD copied to clipboard

Tforkner/3745 api budget

Open thetif opened this issue 2 years ago • 1 comments

Resolves #3745

Description

Significant changes or possible side effects

Automated test cases written

Steps to manually verify this change

This pull request is ready to review when

  • [ ] Automated tests are updated (and all tests are passing)
  • [ ] Pull request has been labeled, if applicable with feature, content, bug, tests, refactor
  • [ ] Associated OpenAPI documentation has been updated
  • [ ] The experience passes a basic manual accessibility audit (keyboard nav, screenreader, text scaling) OR an exemption is documented

This pull request can be merged when

  • [ ] Code has been reviewed by someone other than the original author
  • [ ] QA has verified the functionality related to the change
  • [ ] QA has verified the accessibility using tools such as screen readers and WAVE (accessibility evaluation tool)
  • [ ] Design has approved the experience
  • [ ] Product has approved the experience

thetif avatar Aug 18 '22 14:08 thetif

Codecov Report

Merging #4276 (96f96d7) into main (5de83e4) will decrease coverage by 0.03%. The diff coverage is 91.25%.

:exclamation: Current head 96f96d7 differs from pull request most recent head 8895b62. Consider uploading reports for the commit 8895b62 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4276      +/-   ##
==========================================
- Coverage   85.98%   85.95%   -0.04%     
==========================================
  Files         260      262       +2     
  Lines        5980     5993      +13     
  Branches     1264     1267       +3     
==========================================
+ Hits         5142     5151       +9     
- Misses        775      779       +4     
  Partials       63       63              
Impacted Files Coverage Δ
api/db/certifications.js 63.33% <ø> (ø)
web/src/components/DeleteModal.js 100.00% <ø> (ø)
web/src/components/RichText.js 80.88% <ø> (ø)
web/src/layout/nav/Nav.js 100.00% <ø> (ø)
...vities/activities-dashboard/ActivitiesDashboard.js 100.00% <ø> (ø)
...ctivities/activities-dashboard/ActivityReadOnly.js 90.00% <ø> (ø)
...vities/cost-allocation/CostAllocateFFPQuarterly.js 89.28% <0.00%> (ø)
...ies/cost-allocation/CostAllocation/CostAllocate.js 89.47% <ø> (ø)
...ies/cost-allocation/CostAllocation/OtherFunding.js 61.11% <ø> (ø)
...eb/src/pages/apd/activities/ffp/CostAllocateFFP.js 93.54% <ø> (ø)
... and 30 more

Impacted file tree graph

Impacted Files Coverage Δ
api/db/certifications.js 63.33% <ø> (ø)
web/src/components/DeleteModal.js 100.00% <ø> (ø)
web/src/components/RichText.js 80.88% <ø> (ø)
web/src/layout/nav/Nav.js 100.00% <ø> (ø)
...vities/activities-dashboard/ActivitiesDashboard.js 100.00% <ø> (ø)
...ctivities/activities-dashboard/ActivityReadOnly.js 90.00% <ø> (ø)
...vities/cost-allocation/CostAllocateFFPQuarterly.js 89.28% <0.00%> (ø)
...ies/cost-allocation/CostAllocation/CostAllocate.js 89.47% <ø> (ø)
...ies/cost-allocation/CostAllocation/OtherFunding.js 61.11% <ø> (ø)
...eb/src/pages/apd/activities/ffp/CostAllocateFFP.js 93.54% <ø> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5de83e4...8895b62. Read the comment docs.

codecov-commenter avatar Aug 18 '22 15:08 codecov-commenter

This deploy was cleaned up.

cms-eapd-bot avatar Sep 16 '22 15:09 cms-eapd-bot

Looks good to me! Manually walked through the app and fidgeted with some budget stuff.

mirano-darren avatar Sep 29 '22 19:09 mirano-darren