eAPD
eAPD copied to clipboard
Nz/validate incentive payment
Resolves #3356
Description
Add inline validation for Proposed Budget
This pull request is ready to review when
- [x] Automated tests are updated (and all tests are passing)
- [ ] Pull request has been labeled, if applicable with feature, content, bug, tests, refactor
- [ ] Associated OpenAPI documentation has been updated
- [ ] The experience passes a basic manual accessibility audit (keyboard nav, screenreader, text scaling) OR an exemption is documented
This pull request can be merged when
- [x] Code has been reviewed by someone other than the original author
- [ ] QA has verified the functionality related to the change
- [ ] QA has verified the accesibility using tools such as screen readers and WAVE (accessibility evaluation tool)
- [ ] Design has approved the experience
- [ ] Product has approved the experience
Codecov Report
Merging #4273 (8ac505d) into main (9793115) will decrease coverage by
0.24%
. The diff coverage is50.00%
.
@@ Coverage Diff @@
## main #4273 +/- ##
==========================================
- Coverage 86.32% 86.08% -0.25%
==========================================
Files 260 260
Lines 5932 5951 +19
Branches 1240 1251 +11
==========================================
+ Hits 5121 5123 +2
- Misses 751 765 +14
- Partials 60 63 +3
Impacted Files | Coverage Δ | |
---|---|---|
...src/pages/apd/proposed-budget/IncentivePayments.js | 70.17% <50.00%> (-29.83%) |
:arrow_down: |
Impacted Files | Coverage Δ | |
---|---|---|
...src/pages/apd/proposed-budget/IncentivePayments.js | 70.17% <50.00%> (-29.83%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 9793115...8ac505d. Read the comment docs.
This deploy was cleaned up.
Looks good to me! Well done!
Given | When | Then | Result |
---|---|---|---|
EQIP Table | A number less than 0 is entered OR a special character is entered | Red box appears around the input field, error message shows at the bottom of the table | PASS ✅ |
EQIP Table | Using a screenreader (NVDA and Narrator) when an invalid number is entered | Error message is read out loud as soon as the input is invalid | PASS ✅ |
EQIP Table | A number >= 0 is entered | Number is considered valid and doesn't show the error message | PASS ✅ |
Note: EH Count can be negative. Should we address this? @jeromeleecms @akuas
Just to simply, I was curious what we decided on for when the system corrects errors when you tab over before approving.
For the error message, is this the one that we said to use the language "Provide a whole number greater than $0."
Also as noted in Slack, what's the expectation for the screen reader when the field auto updates?