Martin Nordholts

Results 180 comments of Martin Nordholts

I'm labeling as "help wanted", because fixing this would substantially improve the user experience for users (especially new ones) that use a light terminal background.

Here is a PR to improve the situation on macOS: https://github.com/sharkdp/bat/pull/2197. Any feedback is very welcomed, including objections to the approach as a whole.

About time to merge this now I think.

To me this sounds like reasonable opt-in functionality, so if someone comes up with a good solution with a good set of integration tests, I think that is something we...

Thank you for working on this. > I think Printer should use fmt::Write, but that's a breaking change If we need to do a breaking change that's fine, we want...

Just to be clear * We should release this (and other 1.0.0 RC changes) as the usual bat 0.x.0 bump, i.e. we should not go directly to 1.0.0 * I...

> Creating bat::PrettyPrinter instance for each file is an option. However it is much slower because bat::PrettyPrinter::new deserializes binary assets and it is time consuming. Just wanted to add a...

Very interesting! I think you are onto something very powerful and useful here. Some high level remarks/questions: * A traditional plug-in system does not require explicitly enabling plug-ins, but instead...

Personally I would consider this to be out-of-scope for `bat`. It would be easy to write a wrapper script that invokes `ls` if the argument is a dir and `bat`...

This has indeed been requested before. I could easily find three examples that have been closed: #1156, #971, #427. Let's keep this one open then and see what happens :)