Enrique Lacal

Results 71 comments of Enrique Lacal

For the second case, we need to include the location if not it will not be unique and will cause problems

@peterbroadhurst Thanks for the comments - will amend the PR with changed. I think the challenge here is the `location:` - The current uniqueness constraints is `location + topic +...

@peterbroadhurst From the review comments and the chances I made, came up with three other worries: - Filtering over certain fields at the API level will be worse as we...

@denisandreenko thanks for the input - so a follow up PR might be needed to provide the user with a better error on event streaming because it seems the code...

Looks like Docker has been update in the Github Action and the packaged docker-compose version no longer support `ContainerConfig` https://github.com/docker/compose/issues/11742#issuecomment-2137583574

The GH action is using V1 for some reason `/usr/local/bin/docker-compose up -d` and it should be using `v2`. FireFly CLI checks if V1 is available and uses that or V2...

This should do the trick https://github.com/hyperledger/firefly-cli/pull/307 - I'll have to update the action to pull in a new version

Thanks for the steer @peterbroadhurst! I had in mind Option 2 as the migration impact of the filtering no longer working doesn't fit in by mind as a 1.3.1 but...

Review with @peterbroadhurst # This is the final proposal for the changes:
 Roughly Option 2 + other changes! - Exactly the same POST inputs for listeners that were accepted previously...

Tested this PR E2E with an EVM chain locally, feeling quite good but I'm seeing problems in the E2E tests when creating a listener. Digging into that...