Enrico Minack

Results 653 comments of Enrico Minack

The following approach allows to add this feature without breaking existing `Retry` subclasses: - Add `is_retry_response(self, method, response)` to `Retry` - Implement it as `return self.is_retry(method, response.status, bool(response.getheader("Retry-After"))` - Have...

A possible workaround **without changing urllib3** is to implement your own `Retry`, add the error code to `status_forcelist` and handle the response in `increment` instead of `is_retry`: Here is a...

@sethmlarson is it worth providing a PR for the non-breaking solution proposed in https://github.com/urllib3/urllib3/issues/1445#issuecomment-890794221?

@sethmlarson ok, let's talk code: #2500. @Mr0grog do you think this would work for you?

I cannot get the docker-compose plugin work with Buildkit. This is my Buildkite pipeline: ``` steps: - label: ':docker: Build test-cpu-...' env: DOCKER_BUILDKIT: 1 COMPOSE_DOCKER_CLI_BUILD: 1 BUILDKIT_PROGRESS: plain plugins: -...

I have found the issue, though I have the right docker-compose version, my docker version is 18.06, where at least 18.09 is needed.

@arturopie @toolmantim What is the outcome of the current hook order? Are no artifacts uploaded on non-zero exit code of the container? If so, then the proposed solution would solve...

@toolmantim would that only mean to rename `hooks/pre-exit` to `hooks/pre-artifact`? There is only `compose_cleanup` happening in `pre-exit`.

That is interesting, definitively a good way to draw attention to the relevant numbers.

SVG gives you more power to render your results, compared to GitHub Markdown. But that action generates the SVG images on http://svg.test-summary.com. So it uses a HTTP endpoint to render...