Gitako icon indicating copy to clipboard operation
Gitako copied to clipboard

Published 20 hours ago • verified publisher icon EnixCoda

Handle double (or even more) slashes in URL

Open EnixCoda opened this issue 2 years ago • 3 comments

Such URL can take users to the desired page but Gitako cannot resolve the tree properly, because the URL contains double slashes // after github.com.

https://github.com//EnixCoda/Gitako/pull/247

EnixCoda avatar Jul 27 '22 07:07 EnixCoda

FYI, this is what we use in Refined GitHub: https://github.com/refined-github/github-url-detection/blob/1663cd904c179a5fbd95c008d3a54f400a02162c/index.ts#L686-L687

kidonng avatar Jul 27 '22 07:07 kidonng

FYI, this is what we use in Refined GitHub: https://github.com/refined-github/github-url-detection/blob/1663cd904c179a5fbd95c008d3a54f400a02162c/index.ts#L686-L687

@kidonng Thanks, I have read some source code last time you shared it with me.

EnixCoda avatar Jul 27 '22 09:07 EnixCoda

Reiterating what I said in #243: this issue is different and simpler, we just drop duplicates.

kidonng avatar Jul 27 '22 10:07 kidonng

Fixed in v3.8.3

EnixCoda avatar Aug 21 '22 16:08 EnixCoda