graphql-java-annotations icon indicating copy to clipboard operation
graphql-java-annotations copied to clipboard

Support of inherited interfaces

Open mattesja opened this issue 7 years ago • 1 comments

Only direct implemented interfaces are supported when building a GraphQLObjectType.

class MyObject implements MyInterface {} => OK

class MyObject2 extends MyObject {} => No interface in ObjectType

ClassUtils.getAllInterfaces(object) should be used instead of object.getInterfaces()

Would you accept such a pull request adding such a dependency on apache-commons-lang?

mattesja avatar Feb 15 '17 15:02 mattesja

Please make a PR

guy120494 avatar May 07 '18 17:05 guy120494

Hi @mattesja,

We're helping with project maintenance and reviewing the list of opened PRs and Issues.

This issue was created quite a while ago, we were wondering if you were still interested in the outcome, please let us know if this is the case.

Without an answer by July 1st, 2023, this issue will be closed as "inactive" (and can always be re-opened later on if needed).

Thanks,

Fgerthoffert avatar Jun 02 '23 08:06 Fgerthoffert

While not the original reporter, I am still interested in this and will try to put together a PR for it.

richharms avatar Jul 29 '23 21:07 richharms

Any update on the PR ? Otherwise we can close this issue ?

sergehuber avatar Oct 26 '23 09:10 sergehuber

My apologizes for not getting to this sooner, let me see if I can put something together in the next week. Congrats on a great release, BTW! Easiest one I believe I've ever had for a complex project that integrates this library.

richharms avatar Oct 26 '23 11:10 richharms

Thanks for the PR @richharms , we will be reviewing it soon.

Fgerthoffert avatar Dec 07 '23 10:12 Fgerthoffert

The PR was merged, we are closing the ticket.

Fgerthoffert avatar Jan 10 '24 10:01 Fgerthoffert