graphql-java-annotations icon indicating copy to clipboard operation
graphql-java-annotations copied to clipboard

Published 20 hours ago • verified publisher icon Enigmatis

Adopt is dead, long live Zulu!

Open geertjanw opened this issue 4 years ago • 3 comments

geertjanw avatar Aug 28 '21 20:08 geertjanw

would appreciate elaboration on your change

yarinvak avatar Sep 06 '21 14:09 yarinvak

Adopt no longer exists. Two options for v2 right now are 'temurin' or 'zulu'. The first one, 'temurin' is new, and doesn't have all the releases, e.g., the Temurin history starts from 8.0.302, 11.0.12, and 16.0.2, while Zulu supports all versions of these releases.

geertjanw avatar Sep 06 '21 15:09 geertjanw

Right now you're testing only on '8', which is not a fixed version, but that is whatever the latest version of '8' is. You're recommended as a best practise to set the latest version of a release, as well as a fixed version, so that when your build breaks and the fixed version is green while the latest version is red, you'll know that the broken build is because of the latest version of the JDK and not because of anything in your own code.

Here's an example:

https://github.com/HdrHistogram/HdrHistogram/blob/master/.github/workflows/maven.yml

geertjanw avatar Sep 06 '21 15:09 geertjanw