Enigmatica6 icon indicating copy to clipboard operation
Enigmatica6 copied to clipboard

Shift Crafting Item Deletion

Open Barchtic opened this issue 2 years ago • 8 comments

Modpack Version

1.8.0

Describe your issue.

Excess items will be deleted when shift crafting an item with a full inventory in any crafting inventory (crafting station, crafting table, 4x4 inventory grid). This occurs only when you craft slightly more than a full stack worth of items. Eg. you have one open inventory slot and craft 8 items. You have two slots and craft 15 items. Crafting any more than these quantities will prevent the shift craft but still delete the eighth ingot. (Crafting 9 ingots into one open inventory slot leaves one ingot in the crafting table and deletes the excess nuggets).

This behavior seems to only apply when items are shift crafted into quantities of 9. Such as ingots to nuggets, diamond blocks to diamonds etc. I tried with some blocks that convert into 4 items and it does not allow the craft.

Replicating: Fill an inventory leaving a single slot open for the craft and place 8 items into a crafting grid that will output quantities of higher orders. (Eg. iron ingots to nuggets, redstone blocks to Redstone). Shift craft the items and you should see a full stack and the excess items (72-64=8) will be deleted.

Before: https://i.imgur.com/stsFxBG.jpeg

After: https://i.imgur.com/vKM5qJU.jpeg

Crash Report

No response

Latest Log

No response

Have you modified the modpack?

No

User Modifications

No response

Did the issue happen in singleplayer or on a server?

Both

Discord Username

Barchtic#0666

Barchtic avatar May 08 '23 03:05 Barchtic

Forgot to mention, typical behavior would be dropping the excess items on the ground.

Barchtic avatar May 08 '23 03:05 Barchtic

Thank you for the report, we will investigate the issue.

NielsPilgaard avatar May 08 '23 09:05 NielsPilgaard

I wonder if that's my fault, but such an issue undiscovered as far back as 1.16 would be unusual

Shadows-of-Fire avatar May 08 '23 23:05 Shadows-of-Fire

I was able to reproduce the issue by following the steps provided, so I think you may be at fault here @Shadows-of-Fire 😄

NielsPilgaard avatar May 09 '23 17:05 NielsPilgaard

Does it repro when fastworkbench is removed?

Shadows-of-Fire avatar May 09 '23 18:05 Shadows-of-Fire

Launching to test now :)

NielsPilgaard avatar May 09 '23 19:05 NielsPilgaard

What keeps me skeptical is it happens in the tcon table, which I don't modify.

However, they might be using a copy of my logic, which would have the same problem

Shadows-of-Fire avatar May 09 '23 19:05 Shadows-of-Fire

Ah damn, it's reproducible without FastWorkbench 😄

Perhaps it's an inventory tweaks / mouse tweaks kinda issue.

NielsPilgaard avatar May 09 '23 20:05 NielsPilgaard