Major Infinite Fortune exploit

[Butternubbs]

Modpack Version

1.4.1

Describe your issue.

Apotheosis anvils function strangely with the 'Consistent Luck' Astral Sorcery perk: When holding the anvil, an extra level of Fortune is applied to it, and that enchantment holds when placing the anvil down. If mined and repeated, the anvil's Fortune enchant can stack infinitely. Moving the enchant to a book with the Pressure Chamber allows the player to obtain an infinite Fortune pickaxe, etc. Also works with other enchants such as Unbreaking, Sweeping Edge, etc.

Crash Report

No response

Latest Log

https://gist.github.com/Butternubbs/474e7867c51a3bcc4d2b89909d54cf94

Have you modified the modpack?

No

User Modifications

No response

Did the issue happen in singleplayer or on a server?

Singleplayer

Discord Username

Butternubbs#9827

[NielsPilgaard]

Thanks for the report - this was meant for Enigmatica 6 right? :)

[Butternubbs]

Oops, yeah for 6. Went to the wrong GitHub! 😅

On Mon, Aug 15, 2022 at 12:37 AM Niels Pilgaard Grøndahl < @.***> wrote:

Thanks for the report - this was meant for Enigmatica 6 right? :)

— Reply to this email directly, view it on GitHub https://github.com/EnigmaticaModpacks/Enigmatica6/issues/5167, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJF2SW74ME7MMDXIE27QUATVZHJRVANCNFSM56Q7J6BQ . You are receiving this because you authored the thread.Message ID: @.***>

[NielsPilgaard]

Hmm.. I guess it's actually working as intended :P I think the only solution would be to blacklist anvils, if that's possible. Edit: Not possible 😅

[MuteTiefling]

I thought we could disable specific perks?

[NielsPilgaard]

I might've missed it, but didn't see it in either config :/

[MuteTiefling]

Looks like Shadows can fix this more cleanly from their end. They'll be releasing a fix that'll remove invalid enchants from anvils on placement.

[MuteTiefling]

Apotheosis-1.16.5-4.8.9A0 fixes this

[Vashal0]

I'm sorry it took so long to comment this, I didn't have internet for the last 30 hours. You can do the same enchant dupe with pnc drones.

[MuteTiefling]

Not sure how that works since drones don't get your perks.

Regardless, the patched apotheosis strips invalid enchants when the anvil is placed. Since fortune isn't valid for anvils, it just gets removed.

[Vashal0]

Drones are enchantable, and so they get the Astral perk enchants when held in your hand the same way an anvil does. When put down they keep the enchant just like the anvils did

[MuteTiefling]

Ah, that makes more sense. Will get that reported over to PNC shortly then.

[Shadows-of-Fire]

Sounds like PNC needs to apply the same fix - bleh. That change is here, for reference https://github.com/Shadows-of-Fire/Apotheosis/commit/d80db9c912d976161f0366b758ef384d0bb8004c#diff-935f61a18acf17035df523bcde818dc5a090249192234993045ba5d5a63a2495R91

[Shadows-of-Fire]

Specifically they'll have to do the filtering at this line https://github.com/TeamPneumatic/pnc-repressurized/blob/c792edc19674b4f3b85fd3b95247c3b6683be67c/src/main/java/me/desht/pneumaticcraft/common/entity/living/EntityDrone.java#L283

GitHub

pnc-repressurized/EntityDrone.java at c792edc19674b4f3b85fd3b95247c3b6683be67c · TeamPneumatic/pnc-repressurized

A port of PneumaticCraft to MC1.12+. Contribute to TeamPneumatic/pnc-repressurized development by creating an account on GitHub.